Skip to content

[FirebaseMessaging] Fix crash on Xcode 26 + iOS 18 #15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

[FirebaseMessaging] Fix crash on Xcode 26 + iOS 18 #15164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion FirebaseInAppMessaging/Sources/Runtime/FIRIAMActionURLFollower.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,8 +175,10 @@ - (BOOL)followURLWithContinueUserActivity:(NSURL *)url {
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM240004",
@"App delegate responds to application:continueUserActivity:restorationHandler:."
"Simulating action url opening from a web browser.");
// Use string literal to ensure compatibility with Xcode 26 and iOS 18
NSString *browsingWebType = @"NSUserActivityTypeBrowsingWeb";
NSUserActivity *userActivity =
[[NSUserActivity alloc] initWithActivityType:NSUserActivityTypeBrowsingWeb];
[[NSUserActivity alloc] initWithActivityType:browsingWebType];
userActivity.webpageURL = url;
BOOL handled = [self.appDelegate application:self.mainApplication
continueUserActivity:userActivity
Expand Down
4 changes: 3 additions & 1 deletion FirebaseInAppMessaging/Tests/Unit/FIRIAMActionUrlFollowerTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,10 @@ - (void)testUniversalLinkHandlingReturnYES {
continueUserActivity:[OCMArg checkWithBlock:^BOOL(id userActivity) {
// verifying the type and url field for the userActivity object
NSUserActivity *activity = (NSUserActivity *)userActivity;
// Use string literal to ensure compatibility with Xcode 26 and iOS 18
NSString *browsingWebType = @"NSUserActivityTypeBrowsingWeb";
return [activity.activityType
isEqualToString:NSUserActivityTypeBrowsingWeb] &&
isEqualToString:browsingWebType] &&
[activity.webpageURL isEqual:url];
}]
restorationHandler:[OCMArg any]])
Expand Down
4 changes: 3 additions & 1 deletion FirebaseMessaging/Sources/FIRMessaging.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,8 +400,10 @@ - (void)handleIncomingLinkIfNeededFromMessage:(NSDictionary *)message {
// if they haven't implemented it.
if ([NSUserActivity class] != nil &&
[appDelegate respondsToSelector:continueUserActivitySelector]) {
// Use string literal to ensure compatibility with Xcode 26 and iOS 18
NSString *browsingWebType = @"NSUserActivityTypeBrowsingWeb";
NSUserActivity *userActivity =
[[NSUserActivity alloc] initWithActivityType:NSUserActivityTypeBrowsingWeb];
[[NSUserActivity alloc] initWithActivityType:browsingWebType];
userActivity.webpageURL = url;
[appDelegate application:application
continueUserActivity:userActivity
Expand Down
Loading