-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[FAL] Move useLimitedUseAppCheckTokens property into FirebaseInfo + Update docs #15234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ncooke3 @andrewheard Since Rachel had doc concerns, I decided to just update this PR and push it for this release -- instead of holding off until after the release. |
It's too late for the source changes to end up in the release (no retagging at this point), but the changelog and doc comments should make it to this release's devsite changes. cc: @morganchen12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green CI
Per b/440086625,
This moves the
useLimitedUseAppCheckTokens
property intoFirebaseInfo
. This allows us to avoid needing to propagate down the parameter through model classes, sinceFirebaseInfo
is already passed down.For additional context, see this discussion from the implementation PR.
Note that this PR also updates the
CHANGELOG.md
and docs onuseLimitedUseAppCheckTokens
to reflect the changes Rachel made internally. They now also point to the web page that will go live shortly before the release, which will contain a section detailing limited-use tokens and their usage.#no-changelog