Skip to content

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Aug 20, 2025

Per b/440086625,

This moves the useLimitedUseAppCheckTokens property into FirebaseInfo. This allows us to avoid needing to propagate down the parameter through model classes, since FirebaseInfo is already passed down.

For additional context, see this discussion from the implementation PR.

Note that this PR also updates the CHANGELOG.md and docs on useLimitedUseAppCheckTokens to reflect the changes Rachel made internally. They now also point to the web page that will go live shortly before the release, which will contain a section detailing limited-use tokens and their usage.

#no-changelog

@daymxn daymxn marked this pull request as ready for review August 25, 2025 15:42
@daymxn daymxn requested review from andrewheard and ncooke3 August 25, 2025 15:42
@daymxn
Copy link
Member Author

daymxn commented Aug 25, 2025

@ncooke3 @andrewheard Since Rachel had doc concerns, I decided to just update this PR and push it for this release -- instead of holding off until after the release.

@daymxn daymxn changed the title [FAL] Move useLimitedUseAppCheckTokens property into FirebaseInfo [FAL] Move useLimitedUseAppCheckTokens property into FirebaseInfo + Update docs Aug 25, 2025
@ncooke3
Copy link
Member

ncooke3 commented Aug 25, 2025

@ncooke3 @andrewheard Since Rachel had doc concerns, I decided to just update this PR and push it for this release -- instead of holding off until after the release.

It's too late for the source changes to end up in the release (no retagging at this point), but the changelog and doc comments should make it to this release's devsite changes. cc: @morganchen12

Copy link
Contributor

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

@daymxn daymxn merged commit d119697 into main Aug 25, 2025
45 of 46 checks passed
@daymxn daymxn deleted the daymon-fal-move-limited-use-to-firebaseinfo branch August 25, 2025 19:10
@daymxn daymxn restored the daymon-fal-move-limited-use-to-firebaseinfo branch September 10, 2025 17:50
@firebase firebase locked and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants