Implement a CMake build for FirebaseAuthInterop #1532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
force-pushed
the
wilhuff/firestore-interop
branch
from
710867b to
0f242ed
Compare
paulb777
reviewed
Jul 16, 2018
Firestore/CMakeLists.txt
Outdated
| file( | ||
| WRITE ${CMAKE_CURRENT_BINARY_DIR}/FirebaseAuthInteropDummy.c | ||
| "// generated file for header-only CMake support. | ||
| void FirebaseAuthInteropFakeSymbol() {} |
There was a problem hiding this comment.
How about static int FirebaseAuthInteropFakeSymbol = 1; to avoid cluttering the symbol table?
There was a problem hiding this comment.
Done, though still a static function. Also needed to annotate with __attribute__((unused)) to prevent a compiler error about an unused function.
|
It looks like changing the target branch doesn't trigger travis. And it looks like cmake files should be added to if_changed.sh |
wilhuff
commented
Jul 17, 2018
Firestore/CMakeLists.txt
Outdated
| file( | ||
| WRITE ${CMAKE_CURRENT_BINARY_DIR}/FirebaseAuthInteropDummy.c | ||
| "// generated file for header-only CMake support. | ||
| void FirebaseAuthInteropFakeSymbol() {} |
There was a problem hiding this comment.
Done, though still a static function. Also needed to annotate with __attribute__((unused)) to prevent a compiler error about an unused function.
paulb777
approved these changes
Jul 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks huge but it's basically just a merge of master and #1531 plus just this commit:
710867b.