-
Notifications
You must be signed in to change notification settings - Fork 1.7k
refactor: Remove is_legacy QS testing flags #15353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
37fed4e
refactor: Remove is_legacy QS testing flags
ncooke3 d0f396d
Update qs repo branch testing
ncooke3 3b3e44c
Update testing
ncooke3 b570f39
debug
ncooke3 bc280ce
better qs name
ncooke3 e71e65c
Debug
ncooke3 ef6514a
remove trailing slash
ncooke3 eab3ab1
workflows
ncooke3 9e13000
remove debug
ncooke3 5312f61
crashlytics
ncooke3 b620b61
common qs update
ncooke3 1d68365
workflow refactors
ncooke3 c141e3a
fix setup script
ncooke3 8b82907
*release workflow updates
ncooke3 b9a8211
case sensitive products
ncooke3 601cd1d
disable fail-fast in *release
ncooke3 3f3c256
debug true
ncooke3 38bf3f6
workflow name improvements
ncooke3 d739329
fetch-tags: true
ncooke3 d620e4e
try checkout config change
ncooke3 855a520
m
ncooke3 17e7691
script better error handling
ncooke3 2878050
backtrack
ncooke3 2cbbb9d
fixes
ncooke3 6863092
r
ncooke3 0335a44
SPM=true
ncooke3 f6581a5
set DIR
ncooke3 5c5e3e8
seprate out SPM and CocoaPods workflows
ncooke3 9ae3f4a
maybe: capitalization
ncooke3 7b6c2ba
Revert "maybe: capitalization"
ncooke3 9806577
Reapply "maybe: capitalization"
ncooke3 5173820
install xcpretty
ncooke3 a6efbdf
move
ncooke3 35efc74
storage
ncooke3 80750eb
prerelease, if changes, todo
ncooke3 dc506dd
zip testing
ncooke3 4b41db1
break
ncooke3 c2dd4d8
revertable: disable upload artifact
ncooke3 b995331
unbreak
ncooke3 861e6b1
open
ncooke3 628d537
oh
ncooke3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,8 +45,7 @@ jobs: | |
uses: ./.github/workflows/common_quickstart.yml | ||
with: | ||
product: ABTesting | ||
is_legacy: true | ||
setup_command: QUICKSTART_BRANCH=nc/quickstarts scripts/setup_quickstart_spm.sh abtesting | ||
setup_command: scripts/setup_quickstart_spm.sh abtesting | ||
plist_src_path: scripts/gha-encrypted/qs-abtesting.plist.gpg | ||
plist_dst_path: quickstart-ios/abtesting/GoogleService-Info.plist | ||
secrets: | ||
|
@@ -67,7 +66,6 @@ jobs: | |
# python-version: '3.11' | ||
# - name: Setup quickstart | ||
# env: | ||
# LEGACY: true | ||
# run: scripts/setup_quickstart.sh abtesting | ||
# - name: Install Secret GoogleService-Info.plist | ||
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-abtesting.plist.gpg \ | ||
|
@@ -76,7 +74,6 @@ jobs: | |
# run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
# - name: Build swift quickstart | ||
# env: | ||
# LEGACY: true | ||
# run: ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh ABTesting) | ||
# - id: ftl_test | ||
# uses: FirebaseExtended/github-actions/[email protected] | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,13 +47,7 @@ jobs: | |
uses: ./.github/workflows/common_quickstart.yml | ||
with: | ||
product: Crashlytics | ||
is_legacy: true | ||
setup_command: | | ||
scripts/setup_quickstart.sh crashlytics | ||
mkdir quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics | ||
# Set the deployed pod location of run and upload-symbols with the development pod version. | ||
cp Crashlytics/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/ | ||
cp Crashlytics/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/ | ||
setup_command: scripts/setup_quickstart_spm.sh crashlytics | ||
plist_src_path: scripts/gha-encrypted/qs-crashlytics.plist.gpg | ||
plist_dst_path: quickstart-ios/crashlytics/GoogleService-Info.plist | ||
secrets: | ||
|
@@ -76,20 +70,12 @@ jobs: | |
# run: sudo xcode-select -s /Applications/Xcode_16.4.app/Contents/Developer | ||
# - name: Setup quickstart | ||
# run: scripts/setup_quickstart.sh crashlytics | ||
# env: | ||
# LEGACY: true | ||
# - name: Install Secret GoogleService-Info.plist | ||
# run: scripts/decrypt_gha_secret.sh scripts/gha-encrypted/qs-crashlytics.plist.gpg \ | ||
# quickstart-ios/crashlytics/GoogleService-Info.plist "$plist_secret" | ||
# - name: Build swift quickstart | ||
# run: | | ||
# mkdir quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics | ||
# # Set the deployed pod location of run and upload-symbols with the development pod version. | ||
# cp Crashlytics/run quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/ | ||
# cp Crashlytics/upload-symbols quickstart-ios/crashlytics/LegacyCrashlyticsQuickstart/Pods/FirebaseCrashlytics/ | ||
# ([ -z $plist_secret ] || scripts/third_party/travis/retry.sh scripts/test_quickstart_ftl.sh Crashlytics swift) | ||
# env: | ||
# LEGACY: true | ||
# - id: ftl_test | ||
# uses: FirebaseExtended/github-actions/[email protected] | ||
# with: | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.