Skip to content

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Sep 25, 2025

Make this private setters chain on the context init promise so they won't get dropped before context finishes init process on background.

In Flutter plugin we call native SDK to set development platform name and version, this is early before FIRCLSContext finish initialization(https://screenshot.googleplex.com/63Nwwm3iUFtZVft). This is due to change in #14754

@themiswang themiswang force-pushed the flutterPlatformFix branch 2 times, most recently from 1735b38 to af3b60c Compare September 26, 2025 20:32
@themiswang themiswang marked this pull request as ready for review September 26, 2025 20:32
@themiswang themiswang force-pushed the flutterPlatformFix branch 2 times, most recently from 8474a98 to e4cf36e Compare September 29, 2025 14:15
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 suggestions

@themiswang themiswang changed the title Adding setter APIs to context init promise chain Adding development platform setter APIs to context init promise chain Sep 30, 2025
@themiswang themiswang merged commit ba8674d into main Sep 30, 2025
91 of 105 checks passed
@themiswang themiswang deleted the flutterPlatformFix branch September 30, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants