Fix leak of url sessions in GoogleUtilities #1933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
force-pushed
the
urlsession
branch
2 times, most recently
from
f8cbdef to
3a50f8e
Compare
paulb777
reviewed
Oct 12, 2018
|
Internal code review changes have been patched to this PR. Will merge when TAP passes. |
morganchen12
force-pushed
the
urlsession
branch
from
3a50f8e to
8c61500
Compare
morganchen12
force-pushed
the
urlsession
branch
from
8c61500 to
737c5ac
Compare
|
Test failed on macOS due to Xcode build system crash, merging anyway (all iOS tests pass) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1917 and #1892. This PR takes a more conservative approach, only invalidating at the end of the URL request lifecycle and adds some minor error reporting.