Skip to content

style.sh && merge master #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 47 commits into from
Nov 1, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
9fe54ed
Update versions for Release 5.11.0
ryanwilson Oct 17, 2018
91297fd
Update Firestore Generated Protos (#1972)
schmidt-sebastian Oct 19, 2018
8680441
Remove cruft from project file (#1975)
paulb777 Oct 21, 2018
1dea38c
Lock reads and writes to session map
morganchen12 Oct 19, 2018
ece6b3d
Changed FDL to use compatible __typeof__() operator. (#1982)
Oct 22, 2018
45eaf73
Changed FDL to use compatible __typeof__() operator. (#1982)
Oct 22, 2018
614de80
Bump DynamicLinks patch version
paulb777 Oct 22, 2018
e0a37a9
Merge pull request #1984 from firebase/pb-dl-311
paulb777 Oct 22, 2018
53a2ef3
Add FDL to release manifest
paulb777 Oct 22, 2018
b68f0f9
Merge pull request #1970 from morganchen12/urlsession
morganchen12 Oct 23, 2018
5cfe567
Bump GoogleUtilities patch version to deliver fix for #1964 (#1987)
paulb777 Oct 23, 2018
8de5cb2
Wrap diagnostics notification in collection flag check. (#1979)
ryanwilson Oct 23, 2018
b192fd7
Queue Storage Tasks on separate queue (#1981)
schmidt-sebastian Oct 23, 2018
76a51a5
Increase timeout for testDispatchAfterDelay (#1988)
paulb777 Oct 23, 2018
58b3c08
Update Storage Changelog (#1989)
schmidt-sebastian Oct 23, 2018
44596ad
Add missing FirebaseStorage release note (#1990)
paulb777 Oct 23, 2018
69b17eb
Allow semicolon in file name (#1991)
schmidt-sebastian Oct 23, 2018
ef5949d
Remove unnecessary notification flag (#1993)
ryanwilson Oct 24, 2018
4c50de6
Reduce singleton usage in FIRApp tests. (#1995)
ryanwilson Oct 24, 2018
420dfc2
Comply with c99 standard (#1992)
paulb777 Oct 24, 2018
1d1dd64
Use C99-compatible __typeof__ instead of typeof (#1985)
wilhuff Oct 24, 2018
ec748a5
Merge branch 'master' into release-5.11.0
ryanwilson Oct 24, 2018
abe27db
Merge pull request #2000 from firebase/release-5.11.0
ryanwilson Oct 24, 2018
77f1bee
Adding AppCode Diff (#1996)
schmidt-sebastian Oct 24, 2018
486aa3f
Remove warning (#1999)
wilhuff Oct 24, 2018
648976a
Add InAppMessaging to Carthage template (#2006)
paulb777 Oct 25, 2018
fc2c234
Restore SafariServices framework (#2002)
paulb777 Oct 25, 2018
7d5add3
Force Firestore to conform to C99 and C++11. (#2001)
wilhuff Oct 25, 2018
b032ccc
Changing the internal testing repo (#2003)
davidair Oct 25, 2018
b869115
Clean up test. The issue has already been fixed and we are now runnin…
zxu123 Oct 25, 2018
a514bd9
gRPC: replace Objective-C implementation with the new C++ implementat…
var-const Oct 26, 2018
03a0b0b
Add component system documentation.
ryanwilson Oct 26, 2018
049ba69
Fixed markdown layout issue.
ryanwilson Oct 26, 2018
44d5a0e
Remove trailing whitespaces.
ryanwilson Oct 26, 2018
020c8a0
Merge branch 'rw-component-instructions' of github.com:firebase/fireb…
ryanwilson Oct 26, 2018
07b7ed8
Add table of contents.
ryanwilson Oct 26, 2018
c8c7a04
Remove extra parentheses from TOC.
ryanwilson Oct 26, 2018
b2ba185
Renamed SDKs to frameworks and products for accuracy.
ryanwilson Oct 26, 2018
5a15cf9
Updated the Carthage installation instructions (#2012)
clacladev Oct 26, 2018
9aaef71
Merge pull request #2010 from firebase/rw-component-instructions
ryanwilson Oct 26, 2018
f54b981
Add Rome instructions (#2014)
paulb777 Oct 26, 2018
5e37beb
Attempt to fix frequent Auth Unit Test flake on OSX (#2017)
paulb777 Oct 29, 2018
92a57d7
Increase timeouts in attempt to eliminate travis flakes (#2016)
paulb777 Oct 29, 2018
ea076e3
Don't rely on test always being in foreground (#2021)
paulb777 Oct 29, 2018
dd36990
Fix log overflow in continuous fuzz testing (#2020)
var-const Oct 30, 2018
8ecc4ff
style.sh
rsgowman Oct 30, 2018
7c2cf2b
Merge remote-tracking branch 'origin/master' into rsgowman/nanopb_mas…
rsgowman Oct 30, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions Carthage.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,12 @@
## Context

This page introduces and provides instructions for an **experimental** Firebase
[Carthage](https://github.com/Carthage/Carthage) implementation. Based on
feedback and usage, the Firebase team may decide to make the Carthage
distribution official.
[Carthage](https://github.com/Carthage/Carthage) distribution. Based on
feedback and usage, the Firebase team may decide to [make the Carthage
distribution official](https://github.com/firebase/firebase-ios-sdk/issues/1862).

Please [let us know](https://github.com/firebase/firebase-ios-sdk/issues) if you
have suggestions about how best to distribute Carthage binaries that include
resource bundles.
have suggestions or questions.

## Carthage Installation

Expand All @@ -28,7 +27,7 @@ more details and additional installation methods.

- Create a Cartfile with a **subset** of the following components - choosing the
Firebase components that you want to include in your app. Note that
**FirebaseAnalytics** must always be included.
**FirebaseAnalyticsBinary** must always be included.
```
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseABTestingBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseAdMobBinary.json"
Expand All @@ -39,6 +38,8 @@ binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseDatabaseBinary.js
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseDynamicLinksBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseFirestoreBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseFunctionsBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseInAppMessagingBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseInAppMessagingDisplayBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseInvitesBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseMessagingBinary.json"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseMLModelInterpreterBinary.json"
Expand All @@ -55,8 +56,8 @@ binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseStorageBinary.jso
- Use Finder to open `Carthage/Build/iOS`.
- Copy the contents into the top level of your Xcode project and make sure
they're added to the right build target(s).
- Add the -ObjC flag to "Other Linker Flags".
- Make sure that the build target(s) includes your project's `GoogleService-Info.plist`.
- Add `$(OTHER_LDFLAGS) -ObjC` flag to "Other Linker Flags" in "Build Settings".
- Make sure that the build target(s) includes your project's `GoogleService-Info.plist` ([how to download config file](https://support.google.com/firebase/answer/7015592))
- [Delete Firebase.framework from the Link Binary With Libraries Build Phase](https://github.com/firebase/firebase-ios-sdk/issues/911#issuecomment-372455235).
- If you're including a Firebase component that has resources, copy its bundles
into the Xcode project and make sure they're added to the
Expand Down
2 changes: 1 addition & 1 deletion Example/Auth/Tests/FIRAuthDispatcherTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
@brief The maximum difference between time intervals (in seconds), after which they will be
considered different.
*/
static const NSTimeInterval kMaxDifferenceBetweenTimeIntervals = 0.1;
static const NSTimeInterval kMaxDifferenceBetweenTimeIntervals = 0.3;

/** @var kTestDelay
@brief Fake time delay before tasks are dispatched.
Expand Down
Loading