Unrevert "Revert "gRPC: replace Objective-C implementation with the new C++ implementation (#1968)" #2065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
var-const
commented
Nov 13, 2018
var-const
commented
- revert commit ea567dc;
- merge "gRPC: fix bugs found during testing" gRPC: fix bugs found during testing #2039;
- merge "gRPC: add gRPC wrapper classes to CMake build" gRPC: add gRPC wrapper classes to CMake build #2015.
All in `GrpcStream`: * make sure there are no pending completions when "finish" operation is enqueued; * always finish gRPC calls; * when connectivity changes, reset not just the calls, but the underlying channel as well.
* add a C++ equivalent of `FIRFirestoreVersionString`. This eliminates the only Objective-C dependency of `grpc_connection.mm` and allows making it a pure C++ file; * open-source `binary_to_array.py` script and use it in the build to embed `roots.pem` certificate file from gRPC into the Firestore binary. The embedded char array is then used to load certificate at runtime.
|
@wilhuff Additionally tested on a physical device, my imagination wasn't sufficient to break the app (tried a lot of switching between airplane mode/cellular/Wi-Fi). Let me know if I'm doing something wrong with regards to Git. Note that this also has gRPC CMake changes, which I can split into another PR if necessary. Also, should I readd the changelog entry as part of this PR, too? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.