Skip to content

Unrevert "Revert "gRPC: replace Objective-C implementation with the new C++ implementation (#1968)" #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

var-const
Copy link
Contributor

wilhuff and others added 7 commits November 1, 2018 09:07
All in `GrpcStream`:
* make sure there are no pending completions when "finish" operation is enqueued;
* always finish gRPC calls;
* when connectivity changes, reset not just the calls, but the underlying channel as well.
* add a C++ equivalent of `FIRFirestoreVersionString`. This eliminates the only Objective-C dependency of `grpc_connection.mm` and allows making it a pure C++ file;
* open-source `binary_to_array.py` script and use it in the build to embed `roots.pem` certificate file from gRPC into the Firestore binary. The embedded char array is then used to load certificate at runtime.
@var-const
Copy link
Contributor Author

@wilhuff Additionally tested on a physical device, my imagination wasn't sufficient to break the app (tried a lot of switching between airplane mode/cellular/Wi-Fi). Let me know if I'm doing something wrong with regards to Git. Note that this also has gRPC CMake changes, which I can split into another PR if necessary. Also, should I readd the changelog entry as part of this PR, too?

@var-const var-const closed this Nov 13, 2018
@paulb777 paulb777 deleted the varconst/merge-grpc-master branch October 2, 2019 19:19
@firebase firebase locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants