Forwards app delegate's openURL invocations to FIRAuth.
#207
Conversation
| @@ -312,6 +427,16 @@ - (void)testLegacyDelegateTwoHandlers { | |||
| XCTAssertEqualObjects(delegate.notificationReceived, _notification); | |||
| delegate.notificationReceived = nil; | |||
|
|
|||
| // Verify NOT handling of `application:openURL:sourceApplication:annotation:`. | |||
There was a problem hiding this comment.
Verify application:openURL:sourceApplication:annotation: is NOT handled.
There was a problem hiding this comment.
Done. Also change all instances of "Verify handling of ..." to be "Verify ... is handled" in the entire file to be consistent.
| ([_appDelegate respondsToSelector:openURLOptionsSelector] || | ||
| !([_appDelegate respondsToSelector:openURLAnnotationSelector] || | ||
| [_appDelegate respondsToSelector:handleOpenURLSelector]))) { | ||
| // Replace the modern selector which is avaliable on iOS 9 and above because this is the one |
There was a problem hiding this comment.
Should the above condition be && instead of || ?
There was a problem hiding this comment.
Please see previous response.
| if (&UIApplicationOpenURLOptionsAnnotationKey && // the constant is only available on iOS 9+ | ||
| ([_appDelegate respondsToSelector:openURLOptionsSelector] || | ||
| !([_appDelegate respondsToSelector:openURLAnnotationSelector] || | ||
| [_appDelegate respondsToSelector:handleOpenURLSelector]))) { |
There was a problem hiding this comment.
Should this be negated?
There was a problem hiding this comment.
!(a || b) == !a && !b
Changed to the right side expression as it reads better to you.
| @param url The URL received by the application delegate from any of the openURL method. | ||
| @return Whether or the URL is handled. YES means the URL is for Firebase Auth | ||
| so the caller should ignore the URL from further processing, and NO means the | ||
| the URL is for the app (or another libaray) so the caller should continue handling |
| so the caller should ignore the URL from further processing, and NO means the | ||
| the URL is for the app (or another libaray) so the caller should continue handling | ||
| this URL as usual. | ||
| @remarks If swizzling is disabled, URLs received by application delegate must be forwarded to |
There was a problem hiding this comment.
by "the" application delegate...
| @remarks If swizzling is disabled, URLs received by application delegate must be forwarded to | ||
| this method for phone number auth to work. | ||
| */ | ||
| - (BOOL)canHandleURL:(nonnull NSURL *)url; |
There was a problem hiding this comment.
Is this method necessary for the diff?
There was a problem hiding this comment.
Yes, FIRAuth must conform to FIRAuthAppDelegateHandler. It does nothing yet.
No description provided.