Skip to content

Fix pod lib lint GoogleUtilities.podspec --use-libraries regression #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Fix pod lib lint GoogleUtilities.podspec --use-libraries regression #2130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion GoogleUtilities/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Unreleased
- Fix `pod lib lint GoogleUtilities.podspec --use-libraries` regression. (#2130)

# 5.3.6
- Fix nullability issues. (#2079)
Expand All @@ -11,7 +12,7 @@

# 5.3.4
- Fixed a crash caused by unprotected access to sessions in
`GULNetworkURLSession` (#1964).
`GULNetworkURLSession`. (#1964)

# 5.3.3
- Fixed an issue where GoogleUtilities would leak instances of `NSURLSession`.
Expand Down
6 changes: 3 additions & 3 deletions GoogleUtilities/Network/GULNetworkURLSession.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ @implementation GULNetworkURLSession {
#pragma clang diagnostic ignored "-Wunguarded-availability"
/// The session configuration. NSURLSessionConfiguration' is only available on iOS 7.0 or newer.
NSURLSessionConfiguration *_sessionConfig;

/// The current NSURLSession.
NSURLSession *__weak _Nullable _URLSession;
#pragma clang diagnostic pop

/// The path to the directory where all temporary files are stored before uploading.
Expand All @@ -50,9 +53,6 @@ @implementation GULNetworkURLSession {

/// The current request.
NSURLRequest *_request;

/// The current NSURLSession.
NSURLSession *__weak _Nullable _URLSession;
}

#pragma mark - Init
Expand Down