Skip to content

Remove FSTMutationQueue #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Firestore/Example/Tests/Local/FSTLRUGarbageCollectorTests.mm
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@
#import "FIRTimestamp.h"
#import "Firestore/Example/Tests/Util/FSTHelpers.h"
#import "Firestore/Source/Local/FSTLRUGarbageCollector.h"
#import "Firestore/Source/Local/FSTMutationQueue.h"
#import "Firestore/Source/Local/FSTPersistence.h"
#import "Firestore/Source/Model/FSTDocument.h"
#import "Firestore/Source/Model/FSTFieldValue.h"
#import "Firestore/Source/Model/FSTMutation.h"
#import "Firestore/Source/Util/FSTClasses.h"
#include "Firestore/core/src/firebase/firestore/auth/user.h"
#include "Firestore/core/src/firebase/firestore/local/mutation_queue.h"
#include "Firestore/core/src/firebase/firestore/local/query_cache.h"
#include "Firestore/core/src/firebase/firestore/local/reference_set.h"
#include "Firestore/core/src/firebase/firestore/local/remote_document_cache.h"
Expand All @@ -44,6 +44,7 @@
using firebase::firestore::auth::User;
using firebase::firestore::local::LruParams;
using firebase::firestore::local::LruResults;
using firebase::firestore::local::MutationQueue;
using firebase::firestore::local::QueryCache;
using firebase::firestore::local::ReferenceSet;
using firebase::firestore::local::RemoteDocumentCache;
Expand All @@ -64,7 +65,7 @@ @implementation FSTLRUGarbageCollectorTests {
id<FSTPersistence> _persistence;
QueryCache *_queryCache;
RemoteDocumentCache *_documentCache;
id<FSTMutationQueue> _mutationQueue;
MutationQueue *_mutationQueue;
id<FSTLRUDelegate> _lruDelegate;
FSTLRUGarbageCollector *_gc;
ListenSequenceNumber _initialSequenceNumber;
Expand Down Expand Up @@ -96,7 +97,7 @@ - (void)newTestResourcesWithLruParams:(LruParams)lruParams {
_mutationQueue = [_persistence mutationQueueForUser:_user];
_lruDelegate = (id<FSTLRUDelegate>)_persistence.referenceDelegate;
_initialSequenceNumber = _persistence.run("start querycache", [&]() -> ListenSequenceNumber {
[_mutationQueue start];
_mutationQueue->Start();
_gc = _lruDelegate.gc;
return _persistence.currentSequenceNumber;
});
Expand Down Expand Up @@ -447,7 +448,7 @@ - (void)testRemoveOrphanedDocuments {
// serve to keep the mutated documents from being GC'd while the mutations are outstanding.
_persistence.run("actually register the mutations", [&]() {
FIRTimestamp *writeTime = [FIRTimestamp timestamp];
[_mutationQueue addMutationBatchWithWriteTime:writeTime mutations:mutations];
_mutationQueue->AddMutationBatch(writeTime, mutations);
});

// Mark 5 documents eligible for GC. This simulates documents that were mutated then ack'd.
Expand Down
1 change: 0 additions & 1 deletion Firestore/Example/Tests/Local/FSTLevelDBMigrationsTests.mm
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
#import "Firestore/Protos/objc/firestore/local/Mutation.pbobjc.h"
#import "Firestore/Protos/objc/firestore/local/Target.pbobjc.h"
#import "Firestore/Source/Local/FSTLevelDB.h"
#import "Firestore/Source/Local/FSTLevelDBMutationQueue.h"

#include "Firestore/core/src/firebase/firestore/local/leveldb_key.h"
#include "Firestore/core/src/firebase/firestore/local/leveldb_migrations.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
* limitations under the License.
*/

#import "Firestore/Source/Local/FSTLevelDBMutationQueue.h"

#import <XCTest/XCTest.h>

#include <string>
Expand Down Expand Up @@ -81,7 +79,7 @@ - (void)setUp {
_db = [FSTPersistenceTestHelpers levelDBPersistence];
[_db.referenceDelegate addInMemoryPins:&_additionalReferences];

self.mutationQueue = [_db mutationQueueForUser:User("user")].mutationQueue;
self.mutationQueue = [_db mutationQueueForUser:User("user")];
self.persistence = _db;

self.persistence.run("Setup", [&]() { self.mutationQueue->Start(); });
Expand Down
4 changes: 1 addition & 3 deletions Firestore/Example/Tests/Local/FSTMemoryMutationQueueTests.mm
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
* limitations under the License.
*/

#import "Firestore/Source/Local/FSTMemoryMutationQueue.h"

#import "Firestore/Source/Local/FSTMemoryPersistence.h"

#import "Firestore/Example/Tests/Local/FSTMutationQueueTests.h"
Expand Down Expand Up @@ -43,7 +41,7 @@ - (void)setUp {

self.persistence = [FSTPersistenceTestHelpers eagerGCMemoryPersistence];
[self.persistence.referenceDelegate addInMemoryPins:&_additionalReferences];
self.mutationQueue = [self.persistence mutationQueueForUser:User("user")].mutationQueue;
self.mutationQueue = [self.persistence mutationQueueForUser:User("user")];
}

@end
1 change: 0 additions & 1 deletion Firestore/Source/Local/FSTLRUGarbageCollector.mm
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include <queue>
#include <utility>

#import "Firestore/Source/Local/FSTMutationQueue.h"
#import "Firestore/Source/Local/FSTPersistence.h"
#include "Firestore/core/include/firebase/firestore/timestamp.h"
#include "Firestore/core/src/firebase/firestore/model/document_key.h"
Expand Down
13 changes: 9 additions & 4 deletions Firestore/Source/Local/FSTLevelDB.mm
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@

#import "FIRFirestoreErrors.h"
#import "Firestore/Source/Local/FSTLRUGarbageCollector.h"
#import "Firestore/Source/Local/FSTLevelDBMutationQueue.h"
#import "Firestore/Source/Remote/FSTSerializerBeta.h"

#include "Firestore/core/include/firebase/firestore/firestore_errors.h"
#include "Firestore/core/src/firebase/firestore/auth/user.h"
#include "Firestore/core/src/firebase/firestore/core/database_info.h"
#include "Firestore/core/src/firebase/firestore/local/leveldb_key.h"
#include "Firestore/core/src/firebase/firestore/local/leveldb_migrations.h"
#include "Firestore/core/src/firebase/firestore/local/leveldb_mutation_queue.h"
#include "Firestore/core/src/firebase/firestore/local/leveldb_query_cache.h"
#include "Firestore/core/src/firebase/firestore/local/leveldb_remote_document_cache.h"
#include "Firestore/core/src/firebase/firestore/local/leveldb_transaction.h"
Expand Down Expand Up @@ -63,6 +63,7 @@
using firebase::firestore::local::LevelDbDocumentTargetKey;
using firebase::firestore::local::LevelDbMigrations;
using firebase::firestore::local::LevelDbMutationKey;
using firebase::firestore::local::LevelDbMutationQueue;
using firebase::firestore::local::LevelDbQueryCache;
using firebase::firestore::local::LevelDbRemoteDocumentCache;
using firebase::firestore::local::LevelDbTransaction;
Expand Down Expand Up @@ -93,7 +94,9 @@ - (size_t)byteSize;

@property(nonatomic, assign, getter=isStarted) BOOL started;

- (firebase::firestore::local::LevelDbQueryCache *)queryCache;
- (LevelDbQueryCache *)queryCache;

- (LevelDbMutationQueue *)mutationQueueForUser:(const User &)user;

@end

Expand Down Expand Up @@ -280,6 +283,7 @@ @implementation FSTLevelDB {
FSTLevelDBLRUDelegate *_referenceDelegate;
std::unique_ptr<LevelDbQueryCache> _queryCache;
std::set<std::string> _users;
std::unique_ptr<LevelDbMutationQueue> _currentMutationQueue;
}

/**
Expand Down Expand Up @@ -463,9 +467,10 @@ - (LevelDbTransaction *)currentTransaction {

#pragma mark - Persistence Factory methods

- (id<FSTMutationQueue>)mutationQueueForUser:(const User &)user {
- (LevelDbMutationQueue *)mutationQueueForUser:(const User &)user {
_users.insert(user.uid());
return [FSTLevelDBMutationQueue mutationQueueWithUser:user db:self serializer:self.serializer];
_currentMutationQueue.reset(new LevelDbMutationQueue(user, self, self.serializer));
return _currentMutationQueue.get();
}

- (LevelDbQueryCache *)queryCache {
Expand Down
52 changes: 0 additions & 52 deletions Firestore/Source/Local/FSTLevelDBMutationQueue.h

This file was deleted.

181 changes: 0 additions & 181 deletions Firestore/Source/Local/FSTLevelDBMutationQueue.mm

This file was deleted.

Loading