Skip to content

Added encrypted credential files and enable integration tests #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 25, 2019
Merged

Added encrypted credential files and enable integration tests #2412

merged 13 commits into from
Feb 25, 2019

Conversation

renkelvin
Copy link
Contributor

No description provided.

ryanwilson
ryanwilson approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please wait for @paulb777 to confirm.

paulb777
paulb777 approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BTW, you can turn on travis testing for the enable-integration-tests branch by temporarily adding it at https://github.com/firebase/firebase-ios-sdk/blob/master/.travis.yml#L291

@paulb777
Copy link
Member

Looks like an issue in https://travis-ci.org/firebase/firebase-ios-sdk/jobs/496638822

@paulb777
Copy link
Member

Perhaps something from https://stackoverflow.com/questions/34304570/how-to-resolve-the-evp-decryptfinal-ex-bad-decrypt-during-file-decryption?

@renkelvin
Copy link
Contributor Author

I think the issue is that you can't encrypt multiple files. You have to compress then encrypt. travis-ci/travis-ci#8759

@paulb777
Copy link
Member

Looks like encryption is working now, but I suspect something in the HEADER_SEARCH_PATHS in the Sample project is blocking the CocoaPods overrides to find the FirebaseCore headers.

@renkelvin renkelvin requested a review from paulb777 February 25, 2019 03:35
@renkelvin
Copy link
Contributor Author

Encryption should be working now.

paulb777
paulb777 approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the .travis.yml and this looks good to merge.

Thanks for working through this! Your work will make it a lot easier for anyone else to add integration tests.

@renkelvin renkelvin merged commit 9cddf51 into master Feb 25, 2019
@renkelvin renkelvin deleted the enable-integration-tests branch February 25, 2019 19:07
@firebase firebase locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson ryanwilson approved these changes

@Yue-Wang-Google Yue-Wang-Google Yue-Wang-Google approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renkelvin @paulb777 @ryanwilson @Yue-Wang-Google @googlebot