FIRDynamicLink: preserve all parameters passed to initializer #2478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers passed to initializer
dmandar
reviewed
Mar 8, 2019
| } | ||
|
|
||
| - (void)setParametersDictionaryValue:(id)value forKey:(NSString *)key { | ||
| NSMutableDictionary *parametersDictionary = [self.parametersDictionary mutableCopy]; |
There was a problem hiding this comment.
NSMutableDictionary <NSString *, id> *parametersDictionary
|
@maksymmalyhin When will this ticket be merged? Thanks! |
maksymmalyhin
changed the title
|
@harrydema Just merged it. The fix should be available next release. |
|
Thanks for the swift patch @maksymmalyhin 👍 Fingers crossed till testing this on production ✊ 😃 |
Closed
34 tasks
|
Hi. Is the fixation merged and updated in latest sdk? I have installed firebase dynamic link through pod (version: 3.4.3). still didn't get UTM parameters for dynamic_link_first_open event in Conversion. |
|
@mustahsin This fix has been in the last two releases. You can confirm by checking to see that the source changes in this PR are in the sources in your |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #2462
TODO: Tests