Skip to content

Add image on notification support #2491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 11, 2019
Merged

Add image on notification support #2491

merged 8 commits into from
Mar 11, 2019

Conversation

charlotteliang
Copy link
Contributor

Add extensionHelper class that can be used inside notification extension to render image.

paulb777
paulb777 reviewed Mar 8, 2019
View reviewed changes
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Mar 8, 2019
@charlotteliang charlotteliang force-pushed the fcm-image-notification branch from 084710c to 8a6748c Compare March 8, 2019 21:20
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 8, 2019
paulb777
paulb777 approved these changes Mar 9, 2019
View reviewed changes
@charlotteliang charlotteliang requested a review from paulb777 March 11, 2019 19:30
paulb777
paulb777 approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on a green travis run

@charlotteliang charlotteliang merged commit 681a574 into master Mar 11, 2019
@charlotteliang charlotteliang deleted the fcm-image-notification branch March 11, 2019 21:36
renkelvin
renkelvin reviewed Mar 12, 2019
View reviewed changes
paulb777 added a commit that referenced this pull request Mar 18, 2019
@paulb777
Revert #2491
959eb30
paulb777 added a commit that referenced this pull request Mar 18, 2019
@paulb777
Revert #2491 (#2582)
714bb34
paulb777 added a commit that referenced this pull request Mar 18, 2019
@paulb777
Revert #2491 (#2582)
b1f91ba
paulb777 added a commit that referenced this pull request Mar 20, 2019
@paulb777
Release 5.19.0 (#2589)
ef6c538 
* Update versions for Release 5.19.0

* update the changelog (#2583)

* Revert #2491 (#2582)
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@paulb777 @Corrob
Revert #2491 (#2582)
06dccbc
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@paulb777 @Corrob
Release 5.19.0 (#2589)
3cef93b 
* Update versions for Release 5.19.0

* update the changelog (#2583)

* Revert #2491 (#2582)
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@renkelvin renkelvin renkelvin left review comments

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

@morganchen12 morganchen12 Awaiting requested review from morganchen12

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charlotteliang @googlebot @paulb777 @renkelvin