Use free() for memory allocated with malloc. #2513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than delete, which technically results in undefined behaviour.
wilhuff
approved these changes
Mar 11, 2019
| @@ -73,7 +74,7 @@ class String : public util::Comparable<String> { | |||
| } | |||
|
|
|||
| ~String() { | |||
| delete bytes_; | |||
| std::free(bytes_); | |||
There was a problem hiding this comment.
Nice catch. Do you think it would be worth moving this destructor into the .cc to avoid bleeding #include <cstdlib> into all consumers?
There was a problem hiding this comment.
Maybe? Realistically, stdlib.h is pretty much guaranteed to be pulled in regardless. But another decent reason to move it might be to keep the malloc/free in the same file (so it's more obvious when a mismatch occurs.) Moved.
There was a problem hiding this comment.
That's a much better reason than the one I offered :-).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than delete, which technically results in undefined behaviour.