Skip to content

Delete test with new #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2019
Merged

Delete test with new #2514

merged 1 commit into from
Mar 11, 2019

Conversation

paulb777
Copy link
Member

Delete test with new.

This causes build issues in internal system.
Checking for init happens at build time, not runtime.

@paulb777 paulb777 requested a review from tejasd March 11, 2019 16:30
@paulb777 paulb777 requested a review from ryanwilson March 11, 2019 16:30
ryanwilson
ryanwilson reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change this to [[GULRuntimeClassSnapshot alloc] init] instead?

EDIT: Nevermind, it's marked as NS_UNAVAILABLE.

@paulb777 paulb777 merged commit 8a86551 into master Mar 11, 2019
@paulb777 paulb777 deleted the pb-del-new branch March 11, 2019 17:13
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

@tejasd tejasd Awaiting requested review from tejasd

Assignees
No one assigned
Labels
cla: yes GoogleUtilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @ryanwilson @googlebot