extract errorMessage directly from response when server returns 200 #2542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntial=YES Fix #2522. In this case, the server returns an 200 without an error like the following: ``` [response data:] { "error": { "code": 400, "message": "FEDERATED_USER_ID_ALREADY_LINKED", "errors": [ { "message": "FEDERATED_USER_ID_ALREADY_LINKED", "domain": "global", "reason": "invalid" } ] } } ``` Rather, it is directly enclosed in the response with an errorMessage without a structure: ``` [response data:] { key: value ... "errorMessage": "FEDERATED_USER_ID_ALREADY_LINKED", "kind": "identitytoolkit#VerifyAssertionResponse" } ```
Yue-Wang-Google
changed the title
|
@mono0926 reported that this fix fully resolved his issue. This is an important fix and needs to go into M45. A changelog update is made in the same PR as well. @renkelvin when you approve the fix tomorrow morning, feel free to merge it for me as I'll be OOO tomorrow. |
paulb777
reviewed
Mar 13, 2019
paulb777
approved these changes
Mar 13, 2019
There was a problem hiding this comment.
I'm going to approve and merge this in advance of the release freeze.
@renkelvin Please add a review to confirm when you get in.
|
@Yue-Wang-Google Talked with backend folks. It seems it deserve some comments to explain why it's handled differently. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2522.
in case of returnIDPCredential=YES, instead of an error like the following:
the error message is directly enclosed in the response without a structure: