Ensure token refresh notification is triggered any time a new token is refreshed. b/77662386 #2562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlotteliang
requested review from
paulb777,
ryanwilson,
maksymmalyhin and
morganchen12
Corrob
pushed a commit
that referenced
this pull request
Apr 25, 2019
…s refreshed. b/77662386 (#2562)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before there's this strange handler created to finish some logic of defaultTokenWithHandler: and it is only defined and passing in defaultTokenWithHandler: at two places, where the rest of the defaultTokenWithHandler: calls are not. This could cause issue because it contains critical token refresh code. Move the logic inside defaultTokenWithHandler: so it's always triggered and more readable.
So merge repetitive code and move inside defaultTokenWithHandler: and after that I notice fetchDefaultToken call is simply just calling defaultTokenWithHandler:, so remove it too as there are too many layers of calling default token.