Implement oauth secret token in headful-lite. #2663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate TwitterAuth{Provider,Credential}. OAuth sign in flow is now the recommended way to sign in with Twitter.
|
DO_NOT_SUBMIT. Waiting for API approval |
|
Relevant internal bug: b/129413855 |
Yue-Wang-Google
commented
Apr 3, 2019
Yue-Wang-Google
commented
Apr 3, 2019
Yue-Wang-Google
commented
Apr 3, 2019
Yue-Wang-Google
commented
Apr 3, 2019
renkelvin
approved these changes
Apr 3, 2019
Firebase/Auth/Source/AuthProviders/OAuth/FIROAuthCredential_Internal.h
Outdated
Show resolved
Hide resolved
|
Doc just got approved. Submitting. |
Corrob
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Implement oauth secret token in headful-lite. This is useful for Twitter sign in.
* Deprecate TwitterAuth{Provider,Credential}. OAuth sign in flow is now the recommended way to sign in with Twitter.
* Add update OAuth credential to AuthDataResult. Developer can access the secret token from that.
renkelvin
pushed a commit
that referenced
this pull request
May 1, 2019
This reverts commit b30d005. # Conflicts: # Firebase/Auth/Source/Public/FIRTwitterAuthProvider.h
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also deprecate TwitterAuth{Provider,Credential}. OAuth sign in flow is now the recommended way to sign in with Twitter.