Implement app-lifecycle groundwork #2800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
approved these changes
Apr 10, 2019
GoogleDataTransport/GoogleDataTransport/Classes/Public/GDTLifecycle.h
Outdated
Show resolved
Hide resolved
mikehaney24
added a commit
that referenced
this pull request
Apr 13, 2019
* Initial structural work for the google data logger. (#2162) * Inital commit * Remove Example project and replace with test_spec in the podspec * Update gitignore to ignore the generated folder. * Add a script to generate the project. * Add some basic structure and tests. * Remove unnecessary files and address PR feedback. Removes .gitkeep, .gitignore, and .travis.yml files Modifies the root .gitignore to ignore files generated by cocoapod-generate Modifies the root .travis.yml to add this podspec to CI Updates the README with some instructions * Adding googledatalogger branch to travis CI * Adding copyrights to files that were missing them * Move GDLLogTransformer to the public header directory An alternative is to set CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = 'YES', but I'm not sure this will work when publishing the pod. * Add additional base infrastructure for the logging client (#2174) * Generalize the concept of a logSource Rename and change the type of the 'log source' to be more appropriately generalized as a log mapping identifier string. * Expand the API of the logger. * Add infrastructure for log storage. * Add infrastructure for the log writer. * Remove an unnecessary comment. * Style fixes applied * Change a missed assert message to make more sense. * Flesh out the log event and log writer classes (#2175) * Add timekeeping infrastructure. * Add the log proto protocol. * Flesh out the log event a bit. * Flesh out the log writer. * Put in comments for the log proto protocol. * Move queue to a private header and update the TODO. * Add comment about the QoS tier * Fix style * Enable travis for GoogleDataLogger using cocoapods-generate (#2185) * Add logTarget as a property to GDLLogEvent and connect the logger to the writer. * Enabled building and testing GoogleDataLogger in travis using cocoapods-generate * Update Gemfile.lock * Revert "Add logTarget as a property to GDLLogEvent and connect the logger to the writer." This reverts commit cce26d3. * Fix the workspace path. * Add xcpretty gem * Add the test directive to the GoogleDataLogger invocation * Refactor GoogleDataLogger into its own section Also remove GoogleDataLogger from Xcode9.4 pod lib linting, because the failure was not reproducible. * Create a log wrapper and better test GDLLogWriter (#2190) * Add logTarget as a property to GDLLogEvent and connect the logger to the writer. * Create a log wrapper for use with GULLogger. * GDLLogTransformer should inherit <NSObject> and require transform: * Protect against doesNotRespond exceptions and expand tests * Style and a missing @param. * Update a comment * Implement NSSecureCoding protocol for GDLLogEvent (#2191) * Implement NSSecureCodingProtocol for GDLLogEvent * Style changes. * Refactor to address some comments and structure GDLLogEvent and GDLLogProto are moved to the public folder. GDLLogEvent has had some public API moved to a private header. GDLLogWriter now writes the extension object to data after transforming, for serialization purposes. Various headers updated to conform to module header rules. * Create some core infrastructure for backends (#2198) * s/GDLLogClock/GDLClock/ This isn't a class of log clocks, it's a class of clocks. * Create some core infrastructure to support backends and prioritization of logs. * Docs and slight changes to the scorer API. * Missing return statement * Change 'score' terminology to 'prioritize'. Also style issues. * Change the protocol being used for a prioritizer. * Implement -hash and -copy of GDLLogEvent, copy on log, and don't assign extensionBytes in log writer (#2204) * Implement -hash and -copy of GDLLogEvent Also implements a custom setter for setting the extension that changes the default behavior to set extensionBytes upon assignment of extension. Copy the log upon logging, as the comments promised. Remove setting extensionBytes in the log writer. Implement a missing method * Copy the log object upon logging * Don't assign extensionBytes in the log writer * Make an implicit loss of precision explicit. * Add a comment on performance * Add some test helpers and structure for new classes (#2212) * Test helpers for GDLBackend and GDLLogPrioritizer * Add shared uploader structure * Implement some stubbed methods, update umbrella header, add missing test (#2214) * Add missing test * Implement some stubbed methods, update the umbrella header * Implement log storage (#2215) * Implement log storage Includes tests and categories on existing classes to add testing functionality * Better error handling in tye log storage * Style and pod lib lint fixes * Add missing comment * Implement NSSecureCoding for GDLLogStorage (#2216) * Implement NSSecureCoding for GDLLogStorage * Fix style * Rename variable * merge master into googledatalogger branch (#2224) * Clean up FIRAuth bits from FIRApp (#2110) * Clean up FIRAuth bits from FIRApp * Fix tvOS sample's Auth APIs. (#2158) * Update CHANGELOG for Firestore v0.16.1 (#2164) * Update the name of certificates bundle (#2171) To accommodate for release 5.14.0. * Fix format string in FSTRemoteStore error logging (#2172) * C++: replace `FSTMaybeDocumentDictionary` with a C++ equivalent (#2139) Also eliminate most usages of `FSTDocumentKey`, remove most methods from the Objective-C class and make it just a wrapper over `DocumentKey`. The only usage that cannot be directly replaced by C++ `DocumentKey` is in `FSTFieldValue`. * Port performance optimizations to speed up reading large collections from Android (#2140) Straightforward port of firebase/firebase-android-sdk#123. * When searching for gRPC certificates, search the main bundle as well (#2183) When the project is manually configured, it's possible that the certificates file gets added to the main bundle, not the Firestore framework bundle; make sure the bundle can be loaded in that case as well. * Fix Rome instructions (#2184) * Use registerLibrary for pods in Firebase workspace (#2137) * Add versioning to Functions and convert to FIRLibrary * Convert Firestore to FIRLibrary * Point travis to FirebaseCore pre-release for its deps * Update user agent strings to match spec * Port Memory remote document cache to C++ (#2176) * Port Memory remote document cache to C++ * Minor tweaks to release note (#2182) * Minor tweaks * Update CHANGELOG.md * Update CHANGELOG.md * Port leveldb remote document cache to C++ (#2186) * Port leveldb remote document cache * Remove start from persistence interface (#2173) * Remove start from persistence interface, switch FSTLevelDB to use a factory method that returns Status * Fix small typos in public documentation. (#2192) * fix the unit test #1451 (#2187) * Port FSTRemoteDocumentCacheTest to use C++ interface (#2194) * Release 5.15.0 (#2195) * Update versions for Release 5.15.0 * Create 5.15.0.json * Update CHANGELOG for Firestore v0.16.1 (#2164) * Update the name of certificates bundle (#2171) To accommodate for release 5.14.0. * Fix format string in FSTRemoteStore error logging (#2172) * Update CHANGELOG.md * Update 5.15.0.json * Port FSTRemoteDocumentCache (#2196) * Remove FSTRemoteDocumentCache * Fix leaks in Firestore (#2199) * Clean up retain cycle in FSTLevelDB. * Explicitly CFRelease our SCNetworkReachabilityRef. * Make gRPC stream delegates weak * Port DocumentState and UnknownDocument. (#2160) Part of heldwriteacks. Serialization work for this is largely deferred until after nanopb-master is merged with master. * Port FSTMemoryQueryCache to C++ (#2197) * Port FSTLevelDBQueryCache to C++ (#2202) * Port FSTLevelDBQueryCache to C++ * Fix Storage private imports. (#2206) * Add missing Foundation imports to Interop headers (#2207) * Migrate Firestore to the v1 protocol (#2200) * Use python executable directly * python2 is not guaranteed to exist * scripts aren't directly executable on Windows * Add Firestore v1 protos * Point cmake at Firestore v1 protos * Regenerate protobuf-related sources * Make local protos refer to v1 protos * fixup! Regenerate protobuf-related sources * Remove v1beta1 protos * s/v1beta1/v1/g in source. * s/v1beta1/v1/ in the Xcode project * Remove stale bug comments. This was fixed by adding an explicit FieldPath API rather than exposing escaping to the end user. * Add SymbolCollisionTest comment for ARCore (#2210) * Continue work on ReferenceSet (#2213) * Migrate FSTDocumentReference to C++ * Change SortedSet template parameter ordering Makes it easier to specify a comparator without specifying what the empty member of the underlying map is. * Migrate MemoryMutationQueue to C++ references by key * migrate.py * CMake * Finish porting ReferenceSet * Swap reference set implementation * Port MemoryQueryCache to use ported ReferenceSet * Port FSTReferenceSetTest * Port usage for limbo document refs * Port LRU and LocalStore usages * Remove FSTReferenceSet and FSTDocumentReference * Style * Add newline * Implement QueryCache interface and port QueryCache tests (#2209) * Implement QueryCache interface and port tests * Port production usages of QueryCache (#2211) * Remove FSTQueryCache and implementations * Switch size() to size_t * Keep imports consistent (#2217) * Fix private tests by removing unnecessary storyboard entries (#2218) * Fix xcode 9 build of FDLBuilderTestAppObjC (#2219) * Rework FieldMask to use a (ordered) set of FieldPaths (#2136) Rather than a vector. Port of firebase/firebase-android-sdk#137 * Travis to Xcode 10.1 and clang-format to 8.0.0 (tags/google/stable/2018-08-24) (#2222) * Travis to Xcode 10.1 * Update to clang-format 8 * Update clang-format homebrew link * Work around space in filename style.sh issue * Create testing infrastructure that simplifies catching exceptions in dispatch_queues (#2226) * Apply updated clang-format * Add a custom assert and use it instead of NSAssert * Define a shared unit test test class and change unit tests to use it * Add the GDLAssertHelper to be used by GDLAsserts * Change copyright year, style, and only define the assert macro body if !defined(NS_BLOCK_ASSERTIONS) * Remove rvm specification from travis (#2227) * Implement additional tests and enhance GDLLogEvent (#2231) * Move qosTier to the public API and add a custom prioritization dict * Set the default qosTier in each logging API * Change a missing transform: impl to an error, rearrange error enums We can only rearrange the enums because we've not shipped anything yet. * Implement additional tests * Remove extra space Damned flat macbook keyboards. * Refactor to allow injection of fakes, and take warnings seriously (#2232) * Create fakes that can be used during unit tests * Create a private header for the logger * All log storage to be injected into the log writer, and now give logs to log storage. Also changes the tests to use the fakes * Treat all warnings as errors, and warn pedantic * Ok nevermind, don't warn_pedantic. * remove trailing comma * Remove obsolete TODOs Not needed, because a fake is being used. * Add fakes and injection to log storage for the uploader, implement a fast qos test * Move all unit tests to the Tests/Unit folder (#2234) * s/GDLUploader->GDLUploadCoordinator/g and s/GDLLogBackend/GDLLogUploader (#2256) * Implement a clock. (#2273) * Implement a clock. Files to pay attention to: GDLClock.h/m * style * Enhance the log storage class (#2275) * Rename fields related to the previous notion of 'backends' to 'uploaders'. Also changes the declaration of the uploader callback block. * Add the ability to delete a set of logs by filename, and a conversion method for hashes to files. * Change the log storage removeLogs method to be log hashes instead of URLS * Style, and change the completion block to include an error * Change to sync, since async to adding more async created race condition opportunity. * Test new storage methods * Fix coordinator method declarations * Add test-related functionality, make GDLRegistrar thread-safe and tested (#2285) * Add some functionality to the test prioritizer * Change the registrar's API and make it thread safe. * Add an error message enum for a failed upload * Add more functionality to the log storage fake * Make a property readonly. * Implement the upload coordinator (#2290) * Implement the upload coordinator This is a thread safe class to manage the different GDLUploader implementations. * Remove a bad comment * Spelling * Code cleanup (#2297) Add some nullability specifiers, remove a test that won't compile, change the pod gen script. * Update podspec and factor out common test sources (#2336) * Update podspec and factor out common test sources * Add a wifi-only QoS specifier * Change the prioritizer protocol to include upload conditions * Remove an unused log target. * Call unprioritizeLog and remove an assert that wasn't helpful * Put the upload completionBlock on the uploader queue * Fix the CI and podspec. * [DO NOT MERGE TO MASTER] Raise the cocoapods version to 1.6.0.rc.2 * [DO NOT MERGE TO MASTER] Update Gemfile correctly * [DO NOT MERGE TO MASTER] Use the tag, not the version number. * Correct an incorrect commit * Remove the name for standard unit tests * Implement an integration/E2E test of the logging pipeline (#2356) * Move the -removeLog API to be file-private, it's unused publicly. * Remove altering of in flight log set, that's done in the onComplete block * Copy the set of logs given to upload so it's not altered while the pipeline is operating on it. * Implement an integration/E2E test of the library's pipeline Includes a dependency on GCDWebServer in the test_spec to run an HTTP server endpoint that the uploader can upload to. * Rename -protoBytes to -transportBytes * Change the integration test timing * Spelling. * Fix the scheme names in build.sh * Change cocoapods version from 1.6.0.rc.2 to 1.6.0. (#2358) * Change cocoapods version from 1.6.0.rc.2 to 1.6.0. * Update Gemfile.lock * Rename googledatalogger to GoogleDataTransport (#2379) * Rename GoogleDataLogger to GoogleDataTransport All files should be renamed, GDL prefixes should now be GDT. * Remove references to logging and replace with notion of 'transporting' * Style, and cleaning up a few more references * Change travis config to googledatatransport instead of googledatalogger * Add 'upload packages' to allow prioritizers to pass arbitrary data to uploaders (#2470) * Update some comments and move the event clock snapshot to the public header * Create the notion of an 'upload package' This will allow prioritizers to pass arbitrary data to the uploader that might be needed at upload time. * Make the -transportBytes protocol method required. * Make the rest of the framework use the upload package * Style * Remove cct.nanopb.c It was accidentally added. * Implement a stored event object to simplify in-memory storage (#2497) * Implement a stored event object to simplify in-memory storage This will make passing data to the prioritizers and uploaders easier, and it significantly simplifies logic in the storage system while reducing memory footprint. * Remove two files that always seem to sneak in somehow. * Style and a needed cast * Lay the groundwork for CCT support, and include the prioritizer imple… (#2602) * Lay the groundwork for CCT support, and include the prioritizer implementation. * Style * Adjust a flaky test. * Add GoogleDataTransportCCTSupport configs to travis * Fix small issues with travis configs * Fix syntax error in build.sh * Add SpecsStaging as a source for generation of GDTCCT * Address shortening warning * Remove headers that were unintentionally committed. * Make the podspec description != to the summary * Spelling * Expose all properties of a GDTClock, better -hash and -isEqual impls (#2632) * Expose all properties of a GDTClock, add -hash and -isEqual implementations for GDTStoredEvent * Style, remove unused define * Change GDTStoredEvent -isEqual implementation * Remove unintentionally committed files * Implement the CCT proto using nanopb (#2652) * Write scripts to help generate the CCT proto * Expand the event generator to generate consistent events * Add the CCT proto and generator options * Add the nanopb generated sources and nanopb helpers * Ignore the proto-related directories in GDTCCTSupport * Fix whitespace * Clean up generate_cct_protos.sh Use git instead of curl, rename zip to tar.gz, use readonly variables and proper variable expansion * Address review comments Check return of pb_decode correctly. Use more arbitrary numbers for test event data. Reimplement GDTCCTEncodeString more intelligently. Use better initial values for messages. * Fix memory leak in tests * Use FOUNDATION_EXTERN consistently * Fix test name and always initialize nanopb vars. * Change FOUNDATION_EXTERN to FOUNDATION_EXPORT, fix missing assert code * Reinit a corrupted response to the default * Populate an error if decoding the response fails. * Make high priority events force an upload via upload conditions (#2699) * Make high priority events force an upload via upload conditions Forced uploads should be defined as an additional upload condition, as opposed to constructing an ad-hoc upload package. This allows the prioritizer and uploader to do housekeeping more easily. Address a race condition during high-priority event sending in which a package can be asked for whilst the storage is still asking the prioritizer to deprioritize events that have already been removed from disk. * Make _timeMillis in GDTClock be the actual unix time * Style * Implement the CCT prioritizer and an integration test (#2701) * Implement the CCT prioritizer * Add support for high priority uploads * Add an integration test, demonstrating usage of CCT * Update the podspec * Change library podspecs to require 1.5.3, and change old tag string (#2702) * Remove the GULLogger dependency (#2703) * Remove the GULLogger dependency Wrote a quick console logging function that will log to the console in debug mode. * Style * Remove the .proto and .options files from the cocoapod (#2708) * Remove the .proto and .options files from the cocoapod * Update check_whitespace * Implement app-lifecycle groundwork (#2800) * Create the lifecycle class * Add running in background properties and implement archive paths for the stateful classes. * Move -stopTimer into the upload coordinator * Add test for encoding and decoding the storage singleton. * Add a test transport target. * Style * Temporarily commenting out sending lifecycle events. * More style. * Demonstrate that I know what year I made this file * Implement app lifecycle reactivity. (#2801) * Implement app lifecycle reactivity. * Re-enable the lifecycle code * Implement reachability and upload conditions (#2826) * Add a reachability implementation * Add a reachability private header * Define more useful upload conditions and start at 1 instead of 0 * Implement determining upload conditions * Add hooks for lifecycle events to the CCT implementation. * Style * Lower cocoapods required version to 1.4.0 and remove googledatatransport branch from travis config * Add travis_retry for GoogleDataTransport unit tests. The E2E integration tests are a bit flaky.
Corrob
pushed a commit
that referenced
this pull request
Apr 25, 2019
* Initial structural work for the google data logger. (#2162) * Inital commit * Remove Example project and replace with test_spec in the podspec * Update gitignore to ignore the generated folder. * Add a script to generate the project. * Add some basic structure and tests. * Remove unnecessary files and address PR feedback. Removes .gitkeep, .gitignore, and .travis.yml files Modifies the root .gitignore to ignore files generated by cocoapod-generate Modifies the root .travis.yml to add this podspec to CI Updates the README with some instructions * Adding googledatalogger branch to travis CI * Adding copyrights to files that were missing them * Move GDLLogTransformer to the public header directory An alternative is to set CLANG_ALLOW_NON_MODULAR_INCLUDES_IN_FRAMEWORK_MODULES = 'YES', but I'm not sure this will work when publishing the pod. * Add additional base infrastructure for the logging client (#2174) * Generalize the concept of a logSource Rename and change the type of the 'log source' to be more appropriately generalized as a log mapping identifier string. * Expand the API of the logger. * Add infrastructure for log storage. * Add infrastructure for the log writer. * Remove an unnecessary comment. * Style fixes applied * Change a missed assert message to make more sense. * Flesh out the log event and log writer classes (#2175) * Add timekeeping infrastructure. * Add the log proto protocol. * Flesh out the log event a bit. * Flesh out the log writer. * Put in comments for the log proto protocol. * Move queue to a private header and update the TODO. * Add comment about the QoS tier * Fix style * Enable travis for GoogleDataLogger using cocoapods-generate (#2185) * Add logTarget as a property to GDLLogEvent and connect the logger to the writer. * Enabled building and testing GoogleDataLogger in travis using cocoapods-generate * Update Gemfile.lock * Revert "Add logTarget as a property to GDLLogEvent and connect the logger to the writer." This reverts commit cce26d3. * Fix the workspace path. * Add xcpretty gem * Add the test directive to the GoogleDataLogger invocation * Refactor GoogleDataLogger into its own section Also remove GoogleDataLogger from Xcode9.4 pod lib linting, because the failure was not reproducible. * Create a log wrapper and better test GDLLogWriter (#2190) * Add logTarget as a property to GDLLogEvent and connect the logger to the writer. * Create a log wrapper for use with GULLogger. * GDLLogTransformer should inherit <NSObject> and require transform: * Protect against doesNotRespond exceptions and expand tests * Style and a missing @param. * Update a comment * Implement NSSecureCoding protocol for GDLLogEvent (#2191) * Implement NSSecureCodingProtocol for GDLLogEvent * Style changes. * Refactor to address some comments and structure GDLLogEvent and GDLLogProto are moved to the public folder. GDLLogEvent has had some public API moved to a private header. GDLLogWriter now writes the extension object to data after transforming, for serialization purposes. Various headers updated to conform to module header rules. * Create some core infrastructure for backends (#2198) * s/GDLLogClock/GDLClock/ This isn't a class of log clocks, it's a class of clocks. * Create some core infrastructure to support backends and prioritization of logs. * Docs and slight changes to the scorer API. * Missing return statement * Change 'score' terminology to 'prioritize'. Also style issues. * Change the protocol being used for a prioritizer. * Implement -hash and -copy of GDLLogEvent, copy on log, and don't assign extensionBytes in log writer (#2204) * Implement -hash and -copy of GDLLogEvent Also implements a custom setter for setting the extension that changes the default behavior to set extensionBytes upon assignment of extension. Copy the log upon logging, as the comments promised. Remove setting extensionBytes in the log writer. Implement a missing method * Copy the log object upon logging * Don't assign extensionBytes in the log writer * Make an implicit loss of precision explicit. * Add a comment on performance * Add some test helpers and structure for new classes (#2212) * Test helpers for GDLBackend and GDLLogPrioritizer * Add shared uploader structure * Implement some stubbed methods, update umbrella header, add missing test (#2214) * Add missing test * Implement some stubbed methods, update the umbrella header * Implement log storage (#2215) * Implement log storage Includes tests and categories on existing classes to add testing functionality * Better error handling in tye log storage * Style and pod lib lint fixes * Add missing comment * Implement NSSecureCoding for GDLLogStorage (#2216) * Implement NSSecureCoding for GDLLogStorage * Fix style * Rename variable * merge master into googledatalogger branch (#2224) * Clean up FIRAuth bits from FIRApp (#2110) * Clean up FIRAuth bits from FIRApp * Fix tvOS sample's Auth APIs. (#2158) * Update CHANGELOG for Firestore v0.16.1 (#2164) * Update the name of certificates bundle (#2171) To accommodate for release 5.14.0. * Fix format string in FSTRemoteStore error logging (#2172) * C++: replace `FSTMaybeDocumentDictionary` with a C++ equivalent (#2139) Also eliminate most usages of `FSTDocumentKey`, remove most methods from the Objective-C class and make it just a wrapper over `DocumentKey`. The only usage that cannot be directly replaced by C++ `DocumentKey` is in `FSTFieldValue`. * Port performance optimizations to speed up reading large collections from Android (#2140) Straightforward port of firebase/firebase-android-sdk#123. * When searching for gRPC certificates, search the main bundle as well (#2183) When the project is manually configured, it's possible that the certificates file gets added to the main bundle, not the Firestore framework bundle; make sure the bundle can be loaded in that case as well. * Fix Rome instructions (#2184) * Use registerLibrary for pods in Firebase workspace (#2137) * Add versioning to Functions and convert to FIRLibrary * Convert Firestore to FIRLibrary * Point travis to FirebaseCore pre-release for its deps * Update user agent strings to match spec * Port Memory remote document cache to C++ (#2176) * Port Memory remote document cache to C++ * Minor tweaks to release note (#2182) * Minor tweaks * Update CHANGELOG.md * Update CHANGELOG.md * Port leveldb remote document cache to C++ (#2186) * Port leveldb remote document cache * Remove start from persistence interface (#2173) * Remove start from persistence interface, switch FSTLevelDB to use a factory method that returns Status * Fix small typos in public documentation. (#2192) * fix the unit test #1451 (#2187) * Port FSTRemoteDocumentCacheTest to use C++ interface (#2194) * Release 5.15.0 (#2195) * Update versions for Release 5.15.0 * Create 5.15.0.json * Update CHANGELOG for Firestore v0.16.1 (#2164) * Update the name of certificates bundle (#2171) To accommodate for release 5.14.0. * Fix format string in FSTRemoteStore error logging (#2172) * Update CHANGELOG.md * Update 5.15.0.json * Port FSTRemoteDocumentCache (#2196) * Remove FSTRemoteDocumentCache * Fix leaks in Firestore (#2199) * Clean up retain cycle in FSTLevelDB. * Explicitly CFRelease our SCNetworkReachabilityRef. * Make gRPC stream delegates weak * Port DocumentState and UnknownDocument. (#2160) Part of heldwriteacks. Serialization work for this is largely deferred until after nanopb-master is merged with master. * Port FSTMemoryQueryCache to C++ (#2197) * Port FSTLevelDBQueryCache to C++ (#2202) * Port FSTLevelDBQueryCache to C++ * Fix Storage private imports. (#2206) * Add missing Foundation imports to Interop headers (#2207) * Migrate Firestore to the v1 protocol (#2200) * Use python executable directly * python2 is not guaranteed to exist * scripts aren't directly executable on Windows * Add Firestore v1 protos * Point cmake at Firestore v1 protos * Regenerate protobuf-related sources * Make local protos refer to v1 protos * fixup! Regenerate protobuf-related sources * Remove v1beta1 protos * s/v1beta1/v1/g in source. * s/v1beta1/v1/ in the Xcode project * Remove stale bug comments. This was fixed by adding an explicit FieldPath API rather than exposing escaping to the end user. * Add SymbolCollisionTest comment for ARCore (#2210) * Continue work on ReferenceSet (#2213) * Migrate FSTDocumentReference to C++ * Change SortedSet template parameter ordering Makes it easier to specify a comparator without specifying what the empty member of the underlying map is. * Migrate MemoryMutationQueue to C++ references by key * migrate.py * CMake * Finish porting ReferenceSet * Swap reference set implementation * Port MemoryQueryCache to use ported ReferenceSet * Port FSTReferenceSetTest * Port usage for limbo document refs * Port LRU and LocalStore usages * Remove FSTReferenceSet and FSTDocumentReference * Style * Add newline * Implement QueryCache interface and port QueryCache tests (#2209) * Implement QueryCache interface and port tests * Port production usages of QueryCache (#2211) * Remove FSTQueryCache and implementations * Switch size() to size_t * Keep imports consistent (#2217) * Fix private tests by removing unnecessary storyboard entries (#2218) * Fix xcode 9 build of FDLBuilderTestAppObjC (#2219) * Rework FieldMask to use a (ordered) set of FieldPaths (#2136) Rather than a vector. Port of firebase/firebase-android-sdk#137 * Travis to Xcode 10.1 and clang-format to 8.0.0 (tags/google/stable/2018-08-24) (#2222) * Travis to Xcode 10.1 * Update to clang-format 8 * Update clang-format homebrew link * Work around space in filename style.sh issue * Create testing infrastructure that simplifies catching exceptions in dispatch_queues (#2226) * Apply updated clang-format * Add a custom assert and use it instead of NSAssert * Define a shared unit test test class and change unit tests to use it * Add the GDLAssertHelper to be used by GDLAsserts * Change copyright year, style, and only define the assert macro body if !defined(NS_BLOCK_ASSERTIONS) * Remove rvm specification from travis (#2227) * Implement additional tests and enhance GDLLogEvent (#2231) * Move qosTier to the public API and add a custom prioritization dict * Set the default qosTier in each logging API * Change a missing transform: impl to an error, rearrange error enums We can only rearrange the enums because we've not shipped anything yet. * Implement additional tests * Remove extra space Damned flat macbook keyboards. * Refactor to allow injection of fakes, and take warnings seriously (#2232) * Create fakes that can be used during unit tests * Create a private header for the logger * All log storage to be injected into the log writer, and now give logs to log storage. Also changes the tests to use the fakes * Treat all warnings as errors, and warn pedantic * Ok nevermind, don't warn_pedantic. * remove trailing comma * Remove obsolete TODOs Not needed, because a fake is being used. * Add fakes and injection to log storage for the uploader, implement a fast qos test * Move all unit tests to the Tests/Unit folder (#2234) * s/GDLUploader->GDLUploadCoordinator/g and s/GDLLogBackend/GDLLogUploader (#2256) * Implement a clock. (#2273) * Implement a clock. Files to pay attention to: GDLClock.h/m * style * Enhance the log storage class (#2275) * Rename fields related to the previous notion of 'backends' to 'uploaders'. Also changes the declaration of the uploader callback block. * Add the ability to delete a set of logs by filename, and a conversion method for hashes to files. * Change the log storage removeLogs method to be log hashes instead of URLS * Style, and change the completion block to include an error * Change to sync, since async to adding more async created race condition opportunity. * Test new storage methods * Fix coordinator method declarations * Add test-related functionality, make GDLRegistrar thread-safe and tested (#2285) * Add some functionality to the test prioritizer * Change the registrar's API and make it thread safe. * Add an error message enum for a failed upload * Add more functionality to the log storage fake * Make a property readonly. * Implement the upload coordinator (#2290) * Implement the upload coordinator This is a thread safe class to manage the different GDLUploader implementations. * Remove a bad comment * Spelling * Code cleanup (#2297) Add some nullability specifiers, remove a test that won't compile, change the pod gen script. * Update podspec and factor out common test sources (#2336) * Update podspec and factor out common test sources * Add a wifi-only QoS specifier * Change the prioritizer protocol to include upload conditions * Remove an unused log target. * Call unprioritizeLog and remove an assert that wasn't helpful * Put the upload completionBlock on the uploader queue * Fix the CI and podspec. * [DO NOT MERGE TO MASTER] Raise the cocoapods version to 1.6.0.rc.2 * [DO NOT MERGE TO MASTER] Update Gemfile correctly * [DO NOT MERGE TO MASTER] Use the tag, not the version number. * Correct an incorrect commit * Remove the name for standard unit tests * Implement an integration/E2E test of the logging pipeline (#2356) * Move the -removeLog API to be file-private, it's unused publicly. * Remove altering of in flight log set, that's done in the onComplete block * Copy the set of logs given to upload so it's not altered while the pipeline is operating on it. * Implement an integration/E2E test of the library's pipeline Includes a dependency on GCDWebServer in the test_spec to run an HTTP server endpoint that the uploader can upload to. * Rename -protoBytes to -transportBytes * Change the integration test timing * Spelling. * Fix the scheme names in build.sh * Change cocoapods version from 1.6.0.rc.2 to 1.6.0. (#2358) * Change cocoapods version from 1.6.0.rc.2 to 1.6.0. * Update Gemfile.lock * Rename googledatalogger to GoogleDataTransport (#2379) * Rename GoogleDataLogger to GoogleDataTransport All files should be renamed, GDL prefixes should now be GDT. * Remove references to logging and replace with notion of 'transporting' * Style, and cleaning up a few more references * Change travis config to googledatatransport instead of googledatalogger * Add 'upload packages' to allow prioritizers to pass arbitrary data to uploaders (#2470) * Update some comments and move the event clock snapshot to the public header * Create the notion of an 'upload package' This will allow prioritizers to pass arbitrary data to the uploader that might be needed at upload time. * Make the -transportBytes protocol method required. * Make the rest of the framework use the upload package * Style * Remove cct.nanopb.c It was accidentally added. * Implement a stored event object to simplify in-memory storage (#2497) * Implement a stored event object to simplify in-memory storage This will make passing data to the prioritizers and uploaders easier, and it significantly simplifies logic in the storage system while reducing memory footprint. * Remove two files that always seem to sneak in somehow. * Style and a needed cast * Lay the groundwork for CCT support, and include the prioritizer imple… (#2602) * Lay the groundwork for CCT support, and include the prioritizer implementation. * Style * Adjust a flaky test. * Add GoogleDataTransportCCTSupport configs to travis * Fix small issues with travis configs * Fix syntax error in build.sh * Add SpecsStaging as a source for generation of GDTCCT * Address shortening warning * Remove headers that were unintentionally committed. * Make the podspec description != to the summary * Spelling * Expose all properties of a GDTClock, better -hash and -isEqual impls (#2632) * Expose all properties of a GDTClock, add -hash and -isEqual implementations for GDTStoredEvent * Style, remove unused define * Change GDTStoredEvent -isEqual implementation * Remove unintentionally committed files * Implement the CCT proto using nanopb (#2652) * Write scripts to help generate the CCT proto * Expand the event generator to generate consistent events * Add the CCT proto and generator options * Add the nanopb generated sources and nanopb helpers * Ignore the proto-related directories in GDTCCTSupport * Fix whitespace * Clean up generate_cct_protos.sh Use git instead of curl, rename zip to tar.gz, use readonly variables and proper variable expansion * Address review comments Check return of pb_decode correctly. Use more arbitrary numbers for test event data. Reimplement GDTCCTEncodeString more intelligently. Use better initial values for messages. * Fix memory leak in tests * Use FOUNDATION_EXTERN consistently * Fix test name and always initialize nanopb vars. * Change FOUNDATION_EXTERN to FOUNDATION_EXPORT, fix missing assert code * Reinit a corrupted response to the default * Populate an error if decoding the response fails. * Make high priority events force an upload via upload conditions (#2699) * Make high priority events force an upload via upload conditions Forced uploads should be defined as an additional upload condition, as opposed to constructing an ad-hoc upload package. This allows the prioritizer and uploader to do housekeeping more easily. Address a race condition during high-priority event sending in which a package can be asked for whilst the storage is still asking the prioritizer to deprioritize events that have already been removed from disk. * Make _timeMillis in GDTClock be the actual unix time * Style * Implement the CCT prioritizer and an integration test (#2701) * Implement the CCT prioritizer * Add support for high priority uploads * Add an integration test, demonstrating usage of CCT * Update the podspec * Change library podspecs to require 1.5.3, and change old tag string (#2702) * Remove the GULLogger dependency (#2703) * Remove the GULLogger dependency Wrote a quick console logging function that will log to the console in debug mode. * Style * Remove the .proto and .options files from the cocoapod (#2708) * Remove the .proto and .options files from the cocoapod * Update check_whitespace * Implement app-lifecycle groundwork (#2800) * Create the lifecycle class * Add running in background properties and implement archive paths for the stateful classes. * Move -stopTimer into the upload coordinator * Add test for encoding and decoding the storage singleton. * Add a test transport target. * Style * Temporarily commenting out sending lifecycle events. * More style. * Demonstrate that I know what year I made this file * Implement app lifecycle reactivity. (#2801) * Implement app lifecycle reactivity. * Re-enable the lifecycle code * Implement reachability and upload conditions (#2826) * Add a reachability implementation * Add a reachability private header * Define more useful upload conditions and start at 1 instead of 0 * Implement determining upload conditions * Add hooks for lifecycle events to the CCT implementation. * Style * Lower cocoapods required version to 1.4.0 and remove googledatatransport branch from travis config * Add travis_retry for GoogleDataTransport unit tests. The E2E integration tests are a bit flaky.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.