Skip to content

FIRApp - validate app name using NSCharacterSet #2906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2019
Merged

FIRApp - validate app name using NSCharacterSet #2906

merged 2 commits into from
Apr 27, 2019

Conversation

maksymmalyhin
Copy link
Contributor

Fixes #2609

paulb777
paulb777 approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you verify that the console allows non-ascii alphabetic characters?

If so, LGTM.

@maksymmalyhin
Copy link
Contributor Author

@paulb777 Looks like the console allows non-ascii alphabetic characters for an app name:

Screen Shot 2019-04-26 at 8 05 51 PM

@maksymmalyhin maksymmalyhin merged commit e04b6ba into master Apr 27, 2019
@maksymmalyhin maksymmalyhin deleted the mm/app-name branch April 27, 2019 00:10
@paulb777 paulb777 added this to the M48 milestone Apr 27, 2019
@paulb777
Copy link
Member

Marked for M48

@firebase firebase locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

Application Name with accent character causes exception.
3 participants
@maksymmalyhin @paulb777 @googlebot