Skip to content

Early return from sending analytics events if instance ID is nil #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2019
Merged

Early return from sending analytics events if instance ID is nil #3007

merged 1 commit into from
May 15, 2019

Conversation

christibbs
Copy link
Contributor

Fixes #2988, where nil instance ID was being inserted into an NSDictionary.

@christibbs christibbs requested a review from ryanwilson May 15, 2019 15:49
@ryanwilson ryanwilson added this to the M48 milestone May 15, 2019
ryanwilson
ryanwilson approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once Travis is green.

@christibbs christibbs merged commit 211ac53 into master May 15, 2019
@christibbs christibbs deleted the fiam-fix-instance-id-crash branch May 15, 2019 17:04
maksymmalyhin pushed a commit that referenced this pull request May 15, 2019
@christibbs @maksymmalyhin
Early return from sending analytics events in instance ID is nil (#3007)
1887e85
maksymmalyhin added a commit that referenced this pull request May 15, 2019
@maksymmalyhin
Release 6.1.0 - cherry pick of #3007 (#3011)
2b1a444 
* 6.1.0 manifest updated. FirebaseInAppMessaging bumped to 0.14.1

* Early return from sending analytics events in instance ID is nil (#3007)
maksymmalyhin added a commit that referenced this pull request May 21, 2019
@maksymmalyhin
Merging the 6.1.0 release into master (#3049)
39fe9dd 
* Update versions for Release 6.1.0

* Release 6.1.0 - cherry pick of #3007 (#3011)

* 6.1.0 manifest updated. FirebaseInAppMessaging bumped to 0.14.1

* Early return from sending analytics events in instance ID is nil (#3007)
@firebase firebase locked and limited conversation to collaborators Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.

InAppMessaging - A lot of crashes in Crashlytics
3 participants
@christibbs @ryanwilson @googlebot