Skip to content

Release 6.1.0 - cherry pick of #3007 #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2019
Merged

Release 6.1.0 - cherry pick of #3007 #3011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9f346f
6.1.0 manifest updated. FirebaseInAppMessaging bumped to 0.14.1
maksymmalyhin May 15, 2019
1887e85
Early return from sending analytics events in instance ID is nil (#3007)
christibbs May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Firebase/InAppMessaging/Analytics/FIRIAMClearcutLogger.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,13 @@ - (void)logAnalyticsEventForType:(FIRIAMAnalyticsLogEventType)eventType
eventTimeInMs = @((long)nowInMs);
}

if (!iid) {
FIRLogWarning(kFIRLoggerInAppMessaging, @"I-IAM210009",
@"Instance ID is nil, event %ld for campaign ID %@ will not be sent",
(long)eventType, campaignID);
return;
}

NSString *sourceExtensionJsonString =
[self constructSourceExtensionJsonForClearcutWithEventType:eventType
forCampaignID:campaignID
Expand Down
2 changes: 1 addition & 1 deletion FirebaseInAppMessaging.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = 'FirebaseInAppMessaging'
s.version = '0.14.0'
s.version = '0.14.1'
s.summary = 'Firebase In-App Messaging for iOS'

s.description = <<-DESC
Expand Down
1 change: 1 addition & 0 deletions Releases/Manifests/6.1.0.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"FirebaseCore":"6.0.1",
"FirebaseFirestore":"1.3.1",
"FirebaseFunctions":"2.5.1",
"FirebaseInAppMessaging":"0.14.1",
"FirebaseInstanceID":"4.1.0",
"FirebaseMessaging":"4.0.1",
"FirebaseStorage":"3.2.1"
Expand Down