Fix main thread crashing issue, reenable tests. #3974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwilson
requested review from
mikehaney24,
paulb777 and
maksymmalyhin
and removed request for
mikehaney24
maksymmalyhin
approved these changes
Oct 2, 2019
| @@ -37,6 +37,13 @@ BOOL GDTCORReachabilityFlagsContainWWAN(SCNetworkReachabilityFlags flags) { | |||
| #endif // TARGET_OS_IOS | |||
| } | |||
|
|
|||
| @interface GDTCORApplication () { | |||
| /** Private flag to match the existing `readonly` public flag. */ | |||
| BOOL _isRunningInBackground; | |||
There was a problem hiding this comment.
We don't write it from different threads (only read), but it may make sense to add volatile just in case.
There was a problem hiding this comment.
or declare it as an atomic property (which is a bit more common way to declare thread-safe variables)
mikehaney24
reviewed
Oct 2, 2019
Comment on lines
-111
to
+112
| [notifCenter postNotificationName:kGDTCORApplicationDidEnterBackgroundNotification object:nil]; | ||
| [notifCenter postNotificationName:UIApplicationDidEnterBackgroundNotification object:nil]; |
There was a problem hiding this comment.
Why change from the abstracted notification to an iOS-specific one?
There was a problem hiding this comment.
We previously used the abstract one because it triggered each classes' foreground/background flags, but now since the flag moved it's set before the abstracted notification is fired. Meaning: the abstract notification no longer triggers the flag to change, only the iOS specific one does.
paulb777
approved these changes
Oct 2, 2019
schmidt-sebastian
pushed a commit
that referenced
this pull request
Oct 2, 2019
* Fix main thread crashing issue, reenable tests. * Added log, extra check for event generation to prevent early exit. * Temporarily run cron tests for travis. * Revert travis.yml update * Change property to atomic based on review comments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking
applicationStatewhile not on the main thread results in a crash. Revert to using notifications and a flag to track this, but with a single source of truth.Fixes #3973.