Skip to content

FIS: Complex unrecoverable error handling reverted and replaced by a simple log message. #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2019
Merged

FIS: Complex unrecoverable error handling reverted and replaced by a simple log message. #4120

merged 3 commits into from
Oct 21, 2019

Conversation

maksymmalyhin
Copy link
Contributor

  • it appeared that the server can handle the potential amount of invalid requests, so the complex error handling is unnecessary (see go/fis-ios-error-handling).
  • a console message logging is used instead to let developers know about the error

@maksymmalyhin maksymmalyhin merged commit 65ec051 into master Oct 21, 2019
@maksymmalyhin maksymmalyhin deleted the mm/fis-errors branch October 21, 2019 13:38
@firebase firebase locked and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@charlotteliang charlotteliang charlotteliang approved these changes

@paulb777 paulb777 Awaiting requested review from paulb777

Assignees
No one assigned
Labels
api: installations cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maksymmalyhin @charlotteliang @googlebot @google-oss-bot