Skip to content

Build and unit test Database for tvOS #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2017
Merged

Build and unit test Database for tvOS #452

merged 2 commits into from
Nov 14, 2017

Conversation

paulb777
Copy link
Member

Note the leveldb podspec hack is ok for development, but should be really pushed before merging this to master.

ryanwilson
ryanwilson approved these changes Nov 14, 2017
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good call, we should see about making the our actual leveldb podspec support tvOS if we don't find any issues.

@ryanwilson ryanwilson merged commit b2894ff into tvOS_master Nov 14, 2017
@ryanwilson ryanwilson deleted the pb-tv3 branch November 14, 2017 14:05
@paulb777
Copy link
Member Author

cc: @schmidt-sebastian

@firebase firebase locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

@charlotteliang charlotteliang Awaiting requested review from charlotteliang

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulb777 @ryanwilson @googlebot