Skip to content

Add script to clean up generated frameworks #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

anaisbetts
Copy link

@anaisbetts anaisbetts commented Nov 15, 2017

The framework generated by build.swift out of the box needs some work to be compatible with codesign. This commit adds a script that adds in the expected "Versions" folder similar to frameworks generated by Xcode.

Will take any and all feedback / improvements on my poor Bash scripting :)

TODO:

  • macOS build links and codesigns in app
  • iOS build links and codesigns in app
  • iOS app can load in simulator

Closes #455

The framework generated by build.swift out of the box needs some work to
be compatible with codesign. This commit adds a script that adds in the
expected "Versions" folder similar to frameworks generated by Xcode

Closes firebase#455
@anaisbetts
Copy link
Author

anaisbetts commented Nov 15, 2017

This is looking mostly good, but I'm still having trouble generating an Info.plist for the framework that iOS will accept, when I try to run an app with one of the Firebase frameworks embedded, I get (sorry for non-codeblock spew, otherwise it's a single unreadable line):

Failure attempting to launch <XCUIApplicationImpl: 0x60400024d980 co.flightlabs.Flight at /Users/paul/Library/Developer/Xcode/DerivedData/Flight-cbyjdsglmnwngfasdbewusjszwnm/Build/Products/Debug-iphonesimulator/Flight.app>: Error Domain=IXUserPresentableErrorDomain Code=2 "This app was unable to be installed." UserInfo={NSLocalizedDescription=This app was unable to be installed., NSUnderlyingError=0x60400024ae90 {Error Domain=MIInstallerErrorDomain Code=35 "Failed to load Info.plist from bundle at path /Users/paul/Library/Developer/CoreSimulator/Devices/6530A98C-5983-447B-9972-052240711A00/data/Library/Caches/com.apple.mobile.installd.staging/temp.Jl6qEG/extracted/Flight.app/Frameworks/FirebaseCore.framework" UserInfo={LegacyErrorString=PackageInspectionFailed, FunctionName=-[MIBundle _validateWithError:], SourceFileLine=38, NSLocalizedDescription=Failed to load Info.plist from bundle at path /Users/paul/Library/Developer/CoreSimulator/Devices/6530A98C-5983-447B-9972-052240711A00/data/Library/Caches/com.apple.mobile.installd.staging/temp.Jl6qEG/extracted/Flight.app/Frameworks/FirebaseCore.framework}}}

@paulb777
Copy link
Member

Thanks for the PR.

As discussed in #455, it's not clear that this is solving the issue.

Also, we're planning to remove the build.swift script with #444 since its original reason for existence (building drop in replacements of binary CocoaPod static frameworks) is going away. However, we're open to keeping it around if it addresses another use case.

@anaisbetts
Copy link
Author

@paulb777 Ya, given build.swift is about to 🔥, no sense in this PR

@anaisbetts anaisbetts closed this Nov 16, 2017
@anaisbetts anaisbetts deleted the create-versioned-frameworks branch November 16, 2017 05:35
@anaisbetts anaisbetts restored the create-versioned-frameworks branch November 16, 2017 05:35
@firebase firebase locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BuildFrameworks generates frameworks that cannot be signed
3 participants