Auth tvOS build environment + email/password example. #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
reviewed
Nov 15, 2017
| @@ -73,7 +73,9 @@ - (void)getTokenWithCallback:(FIRAuthAPNSTokenCallback)callback { | |||
| } else { | |||
| #pragma clang diagnostic push | |||
| #pragma clang diagnostic ignored "-Wdeprecated-declarations" | |||
| #if !TARGET_OS_TV | |||
There was a problem hiding this comment.
Does the style guide cover #if !?
In some places, #if !defined(TARGET_OS_TV) is preferred.
Also, uglier, but more correct, to also #if the if respondsToSelector ...
There was a problem hiding this comment.
I didn't see it but happy to do !defined instead. Will update it!
There was a problem hiding this comment.
Re: the respondsToSelector, tvOS actually does support the above call, just not this one 😄
There was a problem hiding this comment.
Understood - so the if will always be true on tvOS, but if it wasn't nothing would happen in the else.
If this was pure tvOS code, there would be no reason for the respondsToSelector check, but I'm fine with keeping the code easier to read.
paulb777
approved these changes
Nov 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.