Use brackets for module imports #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
requested review from
ryanwilson,
OleksiyA,
davidair,
protocol86 and
schmidt-sebastian
protocol86
approved these changes
Nov 22, 2017
|
So I don't mind this change, but want to understand the motivating principle behind it so that it can be applied more broadly. Should brackets mean
I don't understand why we would import FirebaseCore differently from e.g. GTMSessionFetcherLogging.h. |
|
Yes, yes and yes. I'm currently updating copybara for the changes from #444 and taking a step towards standardization and consistency and make the transformation rules simpler. GTMSessionFetcher imports should used angled brackets. Most of them do and we should change the rest. |
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.