Skip to content

Document post_install workaround for static library source pod usage #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2017
Merged

Document post_install workaround for static library source pod usage #534

merged 2 commits into from
Dec 5, 2017

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Dec 5, 2017

No description provided.

@paulb777 paulb777 requested a review from ryanwilson December 5, 2017 23:25
morganchen12
morganchen12 approved these changes Dec 5, 2017
View reviewed changes
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: file paths should be in backticks for formatting (patch/FirebaseAnalytics.h) though this isn't consistent with the rest of the file.

@paulb777 paulb777 merged commit a904be7 into master Dec 5, 2017
@paulb777 paulb777 deleted the pb-readme-12-5 branch December 5, 2017 23:56
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
@paulb777
Document post_install workaround for static library source pod usage (f…
070ecfb 
…irebase#534)
@firebase firebase locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulb777 @morganchen12 @googlebot