Skip to content

Updating the Auth header comments for Jazzy syntax #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 6, 2017
Merged

Updating the Auth header comments for Jazzy syntax #535

merged 25 commits into from
Dec 6, 2017

Conversation

alexg33
Copy link
Contributor

@alexg33 alexg33 commented Dec 6, 2017

@c and inline HTML tags were causing errors during doc generation

@paulb777 paulb777 requested a review from protocol86 December 6, 2017 01:38
paulb777
paulb777 requested changes Dec 6, 2017
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Please eliminate the trailing spaces causing travis failures -

$ ! git grep -I ' $'
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuth.h:
Firebase/Auth/Source/Public/FIRAuthErrors.h:
Firebase/Auth/Source/Public/FIRAuthErrors.h:
Firebase/Auth/Source/Public/FIRAuthErrors.h:
Firebase/Auth/Source/Public/FIRAuthErrors.h:
Firebase/Auth/Source/Public/FIRPhoneAuthProvider.h:
Firebase/Auth/Source/Public/FIRPhoneAuthProvider.h:
Firebase/Auth/Source/Public/FIRPhoneAuthProvider.h:
Firebase/Auth/Source/Public/FIRPhoneAuthProvider.h:
Firebase/Auth/Source/Public/FIRPhoneAuthProvider.h:
Firebase/Auth/Source/Public/FIRPhoneAuthProvider.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
Firebase/Auth/Source/Public/FIRUser.h:
The command "! git grep -I ' $'" exited with 1.

@alexg33
Copy link
Contributor Author

alexg33 commented Dec 6, 2017

Ok, fixed all the spacing — and also some random tidbits that got unintentionally dropped. Should be good now? Thanks!

@paulb777
Copy link
Member

paulb777 commented Dec 6, 2017

Thanks @alexg33. @protocol86 or I can squash merge when it goes green on travis. Let me know if you want direct push access to https://github.com/firebase/firebase-ios-sdk

@paulb777 paulb777 merged commit cb5f3ef into firebase:master Dec 6, 2017
zxu123 pushed a commit that referenced this pull request Dec 8, 2017
@alexg33 @zxu123
Updating the Auth header comments for Jazzy syntax (#535)
a43ce62
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
@alexg33 @paulb777
Updating the Auth header comments for Jazzy syntax (firebase#535)
1448a90
@firebase firebase locked and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

+1 more reviewer

@protocol86 protocol86 protocol86 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: auth cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexg33 @paulb777 @protocol86 @googlebot