Add FirebaseFirestore.h to fix Firebase module in source build #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
approved these changes
Dec 6, 2017
|
It's intentional to exclude the version declaration since our internal build system doesn't generate those. |
zxu123
pushed a commit
that referenced
this pull request
Dec 8, 2017
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a second umbrella header so that the Firebase module will include the Firestore umbrella header in source builds.
Changing Firebase.h to check for Firestore-umbrella.h would not work because umbrella headers only get generated by CocoaPods when
use_frameworks!is specified and the name of the umbrella header may or may not be qualified by a target if the Podfile specifies multiple Apple targets.More details internally at b/70281259