Making DocumentSnapshot.data() nullable #553
Conversation
|
|
||
| @import FirebaseFirestore; | ||
|
|
||
| #import <FirebaseFirestore/FIRCollectionReference.h> |
There was a problem hiding this comment.
I'm surprised these are required. @import FirebaseFirestore; should have done this for you.
There was a problem hiding this comment.
Removed. App Code auto-adds them. I need to be more careful here :/
| @end | ||
|
|
||
| /** | ||
| * A `FIRQueryDocumentSnapshot` contains data read from a document in your Firestore database. The |
There was a problem hiding this comment.
Perhaps "contains data read from a document in your Firestore database as a part of a query."
Because these types are related we should add clarifying text here that describes when the two types are used, i.e. DocumentSnapshot for single document gets and listens, QueryDocumentSnapshot for query/collection gets/listens.
There was a problem hiding this comment.
Changed the comments. Let me know what you think since I need to port them to the other platforms.
|
Comments addressed. I left the Is this an update we need to make? Otherwise, I will remove it. |
|
Comments LGTM, please squash and merge. |
Making DocumentSnapshot.data() nullable
This PR makes DocumentSnapshot.data() nullable and introduces a non-nullable QueryDocumentSnapshot type.