FIRApp bundle ID validation: allow exact match for extensions #5531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanwilson
approved these changes
May 5, 2020
FirebaseCore/Sources/FIRBundleUtil.m
Outdated
| return YES; | ||
| } | ||
|
|
||
| if ([GULAppEnvironmentUtil isAppExtension]) { | ||
| // This allows app extensions that have the app's bundle as their prefix to pass this test. |
There was a problem hiding this comment.
Nit: I think we should describe why we're doing this, not what the code is doing. Something like:
A developer could be using the same `FIROptions` for both their app and extension. Since extensions have a suffix added to the bundleID, we consider a matching prefix as valid.
paulb777
approved these changes
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5126