Remove prerelease abseil code #558
Conversation
|
|
||
| #include <assert.h> | ||
|
|
||
| #include <absl/base/internal/endian.h> |
There was a problem hiding this comment.
I assume this file itself has been ported from absl. (Otherwise, all the 'internal' references are a bit scary.)
There was a problem hiding this comment.
This file originated in google3's //strings. It's been open sourced several times: most recently (before firestore) in tensorflow.
Unfortunately, this file is not (perhaps yet) in abseil. On plus side because of their common usage within google3 these macros aren't going away anytime soon. Their status in abseil is essentially that they're required but not a committed interface.
In any case, we're depending on a checked-in stable snapshot of abseil for this so we can control when we update and how to deal with it at the time. Worst case, we check-in a separate snapshot of unaligned_access.h if upstream completely breaks this.
* Add abseil bits to the iOS build * Migrate from prerelease to published abseil bits in ordered_code * Remove prerelease abseil code
* Add abseil bits to the iOS build * Migrate from prerelease to published abseil bits in ordered_code * Remove prerelease abseil code
When we open sourced the iOS SDK we included some prerelease code from the abseil project (with their blessing). Now that abseil has shipped, use the imports of the real sources (in #543 and #550) to implement ordered_code, removing some technical debt.