watchOS support for FirebaseAuth #5585

ryanwilson · 2020-05-12T21:45:58Z

This is a re-implementation of #4632 on top of master, along with some small improvements in code structure that were needed after some refactoring.

Credit goes to @hohteri for doing this work in the first place!

Fix #4621

googlebot · 2020-05-12T21:52:23Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Co-authored-by: Harri Hohteri <[email protected]>

paulb777 · 2020-05-21T21:12:54Z

In this PR or after, please restore the FirebaseStorage watchOS pod lib lint tests removed in #5643 to workaround CocoaPods not being able to handle a test only dependency on FirebaseAuth for linting.

googlebot · 2020-06-11T19:48:10Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2020-06-11T19:52:30Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

ryanwilson · 2020-06-11T19:57:56Z

@hohteri apologies for the trouble, but do you mind commenting here with only "@googlebot I consent." in order to appease the one true googlebot and get the CLA flag working? Hoping to land this very soon.

hohteri · 2020-06-11T20:08:02Z

@googlebot I consent.

googlebot · 2020-06-11T20:08:07Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Tested with a small sample app in SwiftUI with anonymous sign in, email/password sign up and email/password log in.

Co-authored-by: Harri Hohteri <[email protected]>

maksymmalyhin

Great!

maksymmalyhin · 2020-06-12T15:34:10Z

FirebaseAuth/Sources/SystemService/FIRAuthStoredUserManager.h

- (FIRUser *)getStoredUserForAccessGroup:(NSString *)accessGroup
-                       projectIdentifier:(NSString *)projectIdentifier
-                                   error:(NSError *_Nullable *_Nullable)outError;
+- (FIRUser *_Nullable)getStoredUserForAccessGroup:(NSString *)accessGroup


nit: - (nullable FIRUser *)... looks more usual to me but I don't mind leaving it as is.

Originally had it to match the above function, but I'll change them both to nullable.

maksymmalyhin · 2020-06-12T15:38:41Z

FirebaseAuth.podspec

@@ -47,10 +48,12 @@ supports email and password accounts, as well as several 3rd party authenticatio
  s.ios.framework = 'SafariServices'
  s.dependency 'FirebaseCore', '~> 6.8'
  s.dependency 'GoogleUtilities/AppDelegateSwizzler', '~> 6.5'
-  s.dependency 'GoogleUtilities/Environment', '~> 6.5'
+  s.dependency 'GoogleUtilities/Environment', '~> 6.6'


I wonder is there an issue with bumping GoogleUtilities version in this PR as well? Since we use local specs in the tests it should not break anything.

Would you like to update GoogleUtilities changelog in the PR as well?

Yep GoogleUtilities should bump to 6.7 here and in its podspec for the new API

maksymmalyhin · 2020-06-12T15:40:54Z

FirebaseAuth.podspec

@@ -47,10 +48,12 @@ supports email and password accounts, as well as several 3rd party authenticatio
  s.ios.framework = 'SafariServices'
  s.dependency 'FirebaseCore', '~> 6.8'
  s.dependency 'GoogleUtilities/AppDelegateSwizzler', '~> 6.5'


I think, versions of all GoogleUtilities dependencies should be updated

paulb777 · 2020-06-12T15:39:23Z

FirebaseAuth/CHANGELOG.md

@@ -1,3 +1,6 @@
+# Unreleased


Will be 6.7.0 for sure

Discussed offline - will leave it as is until it's released.

paulb777 · 2020-06-12T15:44:08Z

FirebaseAuth/Sources/SystemService/FIRAuthAPNSTokenManager.h

@@ -56,12 +60,21 @@ typedef void (^FIRAuthAPNSTokenCallback)(FIRAuthAPNSToken *_Nullable token,
 */
 - (instancetype)init NS_UNAVAILABLE;

-/** @fn initWithApplication:bundle
+#if TARGET_OS_WATCH


Something like GDTCORPlatform to abstract WKExtension and UIApplication might be cleaner.

Turns out these weren't actually needed - only for Phone Auth which was disabled already 😅 removed. Thanks for making me look a second time!

This is a redo of #5585, which was a re-implementation of #4632. This ignores any changes to GoogleUtilities, those will be done in a later PR to create a common KeyedArchiver utility. Co-authored-by: Harri Hohteri <[email protected]>

ryanwilson · 2020-08-12T18:22:54Z

Closing in favour of the more up to date #6260

* watchOS support for FirebaseAuth. This is a redo of #5585, which was a re-implementation of #4632. This ignores any changes to GoogleUtilities, those will be done in a later PR to create a common KeyedArchiver utility. Co-authored-by: Harri Hohteri <[email protected]> * Fixed lint errors, added GHA tests. * Enabled GHA for PRs as well. Co-authored-by: Harri Hohteri <[email protected]>

googlebot added the cla: yes label May 12, 2020

ryanwilson force-pushed the rw-auth-watchos branch from 33b8b55 to 576feb3 Compare May 12, 2020 21:52

googlebot added cla: no and removed cla: yes labels May 12, 2020

ryanwilson mentioned this pull request May 12, 2020

PR: Auth for watchOS #4632

Closed

google-oss-bot added api: auth GoogleUtilities public-api-change labels May 13, 2020

ryanwilson and others added 3 commits May 13, 2020 08:31

Adding watchOS support to Auth.

5a27d3b

Co-authored-by: Harri Hohteri <[email protected]>

Custom GULSecureCoding keys support.

2654bd3

Style

8409101

ryanwilson force-pushed the rw-auth-watchos branch from 576feb3 to 8409101 Compare May 13, 2020 12:32

Formatting GULSecureCoding

3cb5b2d

ryanwilson added cla: yes and removed cla: no labels Jun 11, 2020

Fixed bad brace location.

30bdda1

googlebot added cla: no and removed cla: yes labels Jun 11, 2020

googlebot added cla: yes and removed cla: no labels Jun 11, 2020

ryanwilson marked this pull request as ready for review June 11, 2020 20:39

Fix API unavailability, build issues.

d0468ad

Tested with a small sample app in SwiftUI with anonymous sign in, email/password sign up and email/password log in.

ryanwilson force-pushed the rw-auth-watchos branch from f16c933 to d0468ad Compare June 12, 2020 03:45

ryanwilson and others added 6 commits June 11, 2020 23:48

Merge branch 'master' into rw-auth-watchos

88c6432

Adding watchOS support to Auth.

152345a

Co-authored-by: Harri Hohteri <[email protected]>

Updated README and CHANGELOG.

9aadcba

Re-enabled tvOS support for signInWithLink

5f73951

Style.

ac51177

Added explicit conformance to NSSecureCoding

5054385

maksymmalyhin approved these changes Jun 12, 2020

View reviewed changes

maksymmalyhin reviewed Jun 12, 2020

View reviewed changes

paulb777 approved these changes Jun 12, 2020

View reviewed changes

ryanwilson added 3 commits June 12, 2020 17:20

Removed unnecessary WKExtensions, updated podpsec.

8720bbe

Revert tvOS removal.

b6e0a24

Revert header change.

61f1b91

paulb777 mentioned this pull request Aug 2, 2020

FR: Firebase Auth support for watchOS #4621

Closed

ryanwilson mentioned this pull request Aug 12, 2020

watchOS support for FirebaseAuth. #6260

Merged

ryanwilson closed this Aug 12, 2020

firebase locked and limited conversation to collaborators Sep 12, 2020

paulb777 deleted the rw-auth-watchos branch January 10, 2021 00:45

watchOS support for FirebaseAuth #5585

watchOS support for FirebaseAuth #5585

Uh oh!

Conversation

ryanwilson commented May 12, 2020 • edited by paulb777 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented May 12, 2020

Uh oh!

paulb777 commented May 21, 2020

Uh oh!

googlebot commented Jun 11, 2020

Uh oh!

googlebot commented Jun 11, 2020

Uh oh!

ryanwilson commented Jun 11, 2020

Uh oh!

hohteri commented Jun 11, 2020

Uh oh!

googlebot commented Jun 11, 2020

Uh oh!

maksymmalyhin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryanwilson commented Aug 12, 2020

Uh oh!

Uh oh!

ryanwilson commented May 12, 2020 •

edited by paulb777

Loading