-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Swift naming StorageVersionString #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM but since it's a breaking change, we should wait until next major version change. On that note - should we have a separate "breaking-changes" branch (Firestore has their own) to merge into. Thoughts?
If you do want a breaking-changes branch it can't be the firestore-api-changes branch since that branch will be short-lived. That branch is batching up a series of changes for the next launch vehicle available once we're ready. Firestore is still beta with a 0.x version so we can do this. The firestore-api-changes branch exists at all only because we want to minimize the number of breaking releases users might encounter. |
Right right, thanks! In that case, we should have one but not include Firestore. |
@wilhuff this is FirebaseStorage, not CloudStore. |
@ulukaya Agreed that this is about storage. I was merely pointing out that it should stay separate from Firestore -- that you shouldn't appropriate firestore-api-changes as a staging ground for your own breaking changes. |
We need to make a coherent version naming strategy for all components. CocoaPods automatically generates version variables like this when it creates (dynamic) frameworks. |
I was thinking about working on a consistent global Firebase versioning scheme for M25, but that's not going to happen. With approval from @schmidt-sebastian, we should go ahead and merge this for M25 |
No description provided.