Add nil check for completion handlers #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yramanchuk
suggested changes
Dec 14, 2017
There was a problem hiding this comment.
You can add "NS_ASSUME_NONNULL_BEGIN / END" to make sure that all other block params are not nullable.
Please add checks here as well:
e412303?diff=unified#diff-61c78c5fed9d99346ed86cc554a3c3afR2764
yramanchuk
suggested changes
Dec 14, 2017
|
|
||
|
|
||
| /*! @typedef textInputCompletionBlock | ||
| NS_ASSUME_NONNULL_BEGIN |
There was a problem hiding this comment.
added line break.
Ivan164
approved these changes
Dec 14, 2017
morganchen12
approved these changes
Dec 14, 2017
yramanchuk
approved these changes
Dec 15, 2017
gsoltis
pushed a commit
that referenced
this pull request
Dec 18, 2017
* Add nullability check for completion handler * Addresses comments * added line break
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Add nullability check for completion handler * Addresses comments * added line break
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds nil check for completion handlers to avoid crashes.