Rename all the onlineStateChanged methods to applyOnlineStateChange. #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
suggested changes
Dec 19, 2017
| NSMutableArray *events = [NSMutableArray array]; | ||
| OCMStub([fakeListener query]).andReturn(query); | ||
| OCMStub([fakeListener clientDidChangeOnlineState:FSTOnlineStateUnknown]) | ||
| OCMStub([fakeListener applyOnlineStateChange:FSTOnlineStateUnknown]) |
There was a problem hiding this comment.
This doesn't seem to follow Objective-C's naming convention as it does not use a suffix that describes the argument. I'm going to suggest applyChangeForOnlineState, but I'm certain that there are better options.
There was a problem hiding this comment.
Renamed to applyChangedOnlineState: per offline discussion.
schmidt-sebastian
approved these changes
Dec 19, 2017
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI- I've gone with applyOnlineStateChange on iOS / Web (to be consistent with applyRemoteEvent, etc.) but handleOnlineStateChange on Android (to be consistent with handleListenEvent, etc.). I'm not sure why the platforms diverged in naming but I don't want to try to clean it up in this PR.