Skip to content

Internal code clean up #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2017
Merged

Internal code clean up #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions Example/Auth/Tests/FIRVerifyPasswordRequestTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@

#import "FIRAuthErrors.h"
#import "FIRAuthBackend.h"
#import "FIRFakeBackendRPCIssuer.h"
#import "FIRVerifyPasswordRequest.h"
#import "FIRVerifyPasswordResponse.h"
#import "FIRFakeBackendRPCIssuer.h"

/** @var kTestAPIKey
@brief Fake API key used for testing.
Expand Down Expand Up @@ -125,9 +125,10 @@ - (void)tearDown {
@brief Tests the verify password request.
*/
- (void)testVerifyPasswordRequest {
FIRVerifyPasswordRequest * request = [[FIRVerifyPasswordRequest alloc] initWithEmail:kTestEmail
password:kTestPassword
requestConfiguration:_requestConfiguration];
FIRVerifyPasswordRequest * request =
[[FIRVerifyPasswordRequest alloc] initWithEmail:kTestEmail
password:kTestPassword
requestConfiguration:_requestConfiguration];
request.returnSecureToken = NO;
[FIRAuthBackend verifyPassword:request
callback:^(FIRVerifyPasswordResponse *_Nullable response,
Expand All @@ -147,9 +148,10 @@ - (void)testVerifyPasswordRequest {
@brief Tests the verify password request with optional fields.
*/
- (void)testVerifyPasswordRequestOptionalFields {
FIRVerifyPasswordRequest * request = [[FIRVerifyPasswordRequest alloc] initWithEmail:kTestEmail
password:kTestPassword
requestConfiguration:_requestConfiguration];
FIRVerifyPasswordRequest * request =
[[FIRVerifyPasswordRequest alloc] initWithEmail:kTestEmail
password:kTestPassword
requestConfiguration:_requestConfiguration];
request.pendingIDToken = kTestPendingToken;
request.captchaChallenge = kTestCaptchaChallenge;
request.captchaResponse = kTestCaptchaResponse;
Expand Down
2 changes: 0 additions & 2 deletions Firebase/Auth/Source/RPCs/FIRCreateAuthURIResponse.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

#import "FIRCreateAuthURIResponse.h"

#import "FIRAuthErrorUtils.h"

@implementation FIRCreateAuthURIResponse

- (BOOL)setWithDictionary:(NSDictionary *)dictionary
Expand Down
2 changes: 0 additions & 2 deletions Firebase/Auth/Source/RPCs/FIRDeleteAccountResponse.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

#import "FIRDeleteAccountResponse.h"

#import "FIRAuthErrorUtils.h"

@implementation FIRDeleteAccountResponse

- (BOOL)setWithDictionary:(NSDictionary *)dictionary
Expand Down
2 changes: 0 additions & 2 deletions Firebase/Auth/Source/RPCs/FIRGetOOBConfirmationCodeResponse.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

#import "FIRGetOOBConfirmationCodeResponse.h"

#import "FIRAuthErrorUtils.h"

NS_ASSUME_NONNULL_BEGIN

/** @var kOOBCodeKey
Expand Down
2 changes: 0 additions & 2 deletions Firebase/Auth/Source/RPCs/FIRResetPasswordResponse.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

#import "FIRResetPasswordResponse.h"

#import "FIRAuthErrorUtils.h"

@implementation FIRResetPasswordResponse

- (BOOL)setWithDictionary:(NSDictionary *)dictionary
Expand Down
2 changes: 0 additions & 2 deletions Firebase/Auth/Source/RPCs/FIRSetAccountInfoResponse.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

#import "FIRSetAccountInfoResponse.h"

#import "FIRAuthErrorUtils.h"

@implementation FIRSetAccountInfoResponseProviderUserInfo

- (instancetype)initWithDictionary:(NSDictionary *)dictionary {
Expand Down
2 changes: 0 additions & 2 deletions Firebase/Auth/Source/RPCs/FIRSignUpNewUserResponse.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

#import "FIRSignUpNewUserResponse.h"

#import "FIRAuthErrorUtils.h"

@implementation FIRSignUpNewUserResponse

- (BOOL)setWithDictionary:(NSDictionary *)dictionary
Expand Down
2 changes: 0 additions & 2 deletions Firebase/Auth/Source/RPCs/FIRVerifyAssertionResponse.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

#import "FIRVerifyAssertionResponse.h"

#import "FIRAuthErrorUtils.h"

@implementation FIRVerifyAssertionResponse

- (BOOL)setWithDictionary:(NSDictionary *)dictionary
Expand Down
2 changes: 0 additions & 2 deletions Firebase/Auth/Source/RPCs/FIRVerifyCustomTokenResponse.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

#import "FIRVerifyCustomTokenResponse.h"

#import "FIRAuthErrorUtils.h"

@implementation FIRVerifyCustomTokenResponse

- (BOOL)setWithDictionary:(NSDictionary *)dictionary
Expand Down
2 changes: 0 additions & 2 deletions Firebase/Auth/Source/RPCs/FIRVerifyPasswordResponse.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@

#import "FIRVerifyPasswordResponse.h"

#import "FIRAuthErrorUtils.h"

@implementation FIRVerifyPasswordResponse

- (BOOL)setWithDictionary:(NSDictionary *)dictionary
Expand Down