Skip to content

Update README for tvOS and include in travis #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,16 +132,18 @@ We've seen an amazing amount of interest and contributions to improve the Fireba
very grateful! We'd like to empower as many developers as we can to be able to use Firebase and
participate in the Firebase community.

### macOS
### macOS and tvOS
FirebaseAuth, FirebaseCore, FirebaseDatabase and FirebaseStorage now compile, run unit tests, and
work on macOS, thanks to contributions from the community. There are a few tweaks needed, like
ensuring iOS-only or macOS-only code is correctly guarded with checks for `TARGET_OS_IOS` and
`TARGET_OS_OSX`.

Keep in mind that macOS is not officially supported by Firebase, and this repository is actively
developed primarily for iOS. While we can catch basic unit test issues with Travis, there may be
some changes where the SDK no longer works as expected on macOS. If you encounter this, please
[file an issue](https://github.com/firebase/firebase-ios-sdk/issues) for it.
work on macOS and tvOS, thanks to contributions from the community. There are a few tweaks needed,
like ensuring iOS-only, macOS-only, or tvOS-only code is correctly guarded with checks for
`TARGET_OS_IOS`, `TARGET_OS_OSX` and `TARGET_OS_TV`.

For tvOS, checkout the [Sample](Example/tvOSSample).

Keep in mind that macOS and tvOS are not officially supported by Firebase, and this repository is
actively developed primarily for iOS. While we can catch basic unit test issues with Travis, there
may be some changes where the SDK no longer works as expected on macOS or tvOS. If you encounter
this, please [file an issue](https://github.com/firebase/firebase-ios-sdk/issues).

## Roadmap

Expand Down
19 changes: 18 additions & 1 deletion test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ test_iOS() {
-workspace Example/Firebase.xcworkspace \
-scheme AllUnitTests_iOS \
-sdk iphonesimulator \
-destination 'platform=iOS Simulator,OS=10.3.1,name=iPhone 7' \
-destination 'platform=iOS Simulator,name=iPhone 7' \
build \
test \
ONLY_ACTIVE_ARCH=YES \
Expand All @@ -39,6 +39,19 @@ test_macOS() {
| xcpretty
}

test_tvOS() {
xcodebuild \
-workspace Example/Firebase.xcworkspace \
-scheme AllUnitTests_tvOS \
-sdk appletvsimulator \
-destination 'platform=tvOS Simulator,name=Apple TV' \
build \
test \
ONLY_ACTIVE_ARCH=YES \
CODE_SIGNING_REQUIRED=NO \
| xcpretty
}

test_iOS; RESULT=$?

if [ $RESULT != 0 ]; then exit $RESULT; fi
Expand All @@ -54,5 +67,9 @@ fi

if [ $RESULT != 0 ]; then exit $RESULT; fi

test_tvOS; RESULT=$?

if [ $RESULT != 0 ]; then exit $RESULT; fi

# Also test Firestore
Firestore/test.sh