Log pending writes when we disable the network #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhuff
reviewed
Jan 2, 2018
|
|
||
| - (void)cleanUpWriteStreamState { | ||
| self.lastBatchSeen = kFSTBatchIDUnknown; | ||
| FSTLog(@"Stopping write stream with %i pending writes", [self.pendingWrites count]); |
There was a problem hiding this comment.
This should be producing a warning. Please make sure your setup is showing it to you.
self.pendingWrites is an NSMutableArray which means count is an NSUInteger, which isn't suitable for direct use with printf format strings.
I think this means the format should be %lu and you need to cast to unsigned long before using it. A comparable usage within the code would be
wilhuff
suggested changes
Jan 2, 2018
added 2 commits
January 2, 2018 13:45
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Log pending writes when we disable the network * Fix formatting * Formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add log line to log pending writes remaining when the network is disabled. Requested by API review.