Skip to content

Add Private path to FIRVersion.h import #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2018
Merged

Add Private path to FIRVersion.h import #607

merged 1 commit into from
Jan 2, 2018

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jan 2, 2018

This is necessary for internal build system.

@paulb777 paulb777 requested review from gsoltis and ryanwilson January 2, 2018 21:57
gsoltis
gsoltis approved these changes Jan 2, 2018
View reviewed changes
Copy link

@gsoltis gsoltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulb777 paulb777 merged commit c4dcfaa into master Jan 2, 2018
@paulb777 paulb777 deleted the pb-private-firversion branch January 2, 2018 23:15
minafarid pushed a commit to minafarid/firebase-ios-sdk that referenced this pull request Jun 6, 2018
@paulb777
Add Private path to FIRVersion.h import (firebase#607)
d17a6a2
@firebase firebase locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

1 more reviewer

@gsoltis gsoltis gsoltis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulb777 @gsoltis @googlebot