Firestore and Swift Package Manager #6072

paulb777 · 2020-07-17T23:43:51Z

Current status is a successful build and run of the Firestore quickstart.

Next steps are to consider merging to master to facilitate early evaluation and to continue conversations about dependency open questions

Dependency Summary:

General porting notes:

Using Xcode 12 beta 2
Started with a master snapshot except boringssl and gRPC which branched from the versions currently depended upon by Firestore via CocoaPods
Strong preference to organize by directories, along with excludes to avoid major performance issues from listing files.
Detailed review of excludes needed. Prototype is a minimally sufficient implementation
Strategy for keeping Package.swift files up-to-date needed

boringssl - branched from January 22 version

Package.swift
TODO: Renaming strategy to avoid symbol collisions with other openssl libraries.

grpc - gRPC-Core 1.28.2 gRPC-C++ 1.28.2 - tagged May 20

Package.swift
Also created two directories to disentangle the public includes for the two libraries from the repo. The directories symbolic link to the public headers.

absl - branched from master July 13

Package.swift
First tried to match CocoaPods multiple-subspec target approach, but gave up due to circular dependencies and SwiftPM not supporting header-only targets
Added #pragma clang diagnostic ignored "-Wmodules-import-nested-redundant" to workaround build error

leveldb - PR

google-oss-bot · 2020-07-17T23:45:06Z

	1 Warning
⚠️	Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

wilhuff · 2020-07-30T16:43:15Z

Package.swift

+        .product(name: "gRPC-cpp", package: "gRPC"),
+      ],
+      path: "Firestore",
+      exclude: [


Why are all these entries necessary? Shouldn't this only consist of things that would otherwise match the sources list?

It's everything under Firestore that is not in sources. A better directory structure for SPM would be putting all sources in one directory. I've sorted the list now.

wilhuff · 2020-07-30T16:44:59Z

Package.swift

+        .headerSearchPath("../"),
+        .headerSearchPath("Source/Public"),
+        .headerSearchPath("Protos/nanopb"),
+        .headerSearchPath("Protos/objc/google/api"),


This is obsolete: we no longer use Objective-C protocol buffers

Removed here and in the podspec

wilhuff · 2020-07-30T16:47:22Z

Package.swift

@@ -84,14 +96,18 @@ let package = Package(
      url: "https://github.com/paulb777/nanopb.git",
      .revision("849a9b82233aaa5af4286c6c594cd831ca48651c")
    ),
+    .package(
+      name: "abseil",
+      url: "https://github.com/paulb777/abseil-cpp.git",


For the purposes of internal experimentation this seems reasonable, but I don't think we should publish this to end users until we've settled how we're going to actually make these dependencies work. The outcome I don't want is that we end up stuck maintaining these ourselves because we've conditioned enough users to use Firestore via SPM that we can't call the experiment a failure.

Side note: I wouldn't be surprised to see SPM establish itself as a C++ dependecy manager, even if it currently lacks features vs CMake. Looking forward to see how Windows support in 5.3 will push that. I also would love to see Android NDK support Swift/SPM..

paulb777 · 2020-07-30T18:36:44Z

I'll make a separate PR for the nanopb change after it tests here.

wilhuff

LGTM

This reverts commit bd0098a.

googlebot added the cla: yes label Jul 17, 2020

paulb777 marked this pull request as draft July 17, 2020 23:44

paulb777 changed the title ~~initial spm firestore~~ Firestore and Swift Package Manager Jul 17, 2020

paulb777 force-pushed the pb-spm-firestore branch from ab7e4ba to b895e5d Compare July 23, 2020 23:14

google-oss-bot added the api: firestore label Jul 23, 2020

paulb777 force-pushed the pb-spm-firestore branch from b895e5d to 6583ad5 Compare July 23, 2020 23:18

google-oss-bot added api: auth public-api-change labels Jul 27, 2020

paulb777 mentioned this pull request Jul 29, 2020

FR: Support for Swift Package Manager #3136

Closed

paulb777 force-pushed the pb-spm-firestore branch from 11ef9a3 to 7d94469 Compare July 29, 2020 18:55

google-oss-bot added api: crashlytics GoogleDataTransport labels Jul 29, 2020

paulb777 force-pushed the pb-spm-firestore branch 3 times, most recently from 329f721 to d8bb29e Compare July 30, 2020 14:03

paulb777 marked this pull request as ready for review July 30, 2020 14:37

paulb777 assigned wilhuff Jul 30, 2020

paulb777 removed GoogleDataTransport api: auth api: crashlytics public-api-change labels Jul 30, 2020

wilhuff reviewed Jul 30, 2020

View reviewed changes

paulb777 force-pushed the pb-spm-firestore branch from d8bb29e to 8da13b2 Compare July 30, 2020 18:04

google-oss-bot added api: crashlytics GoogleDataTransport labels Jul 30, 2020

paulb777 mentioned this pull request Jul 30, 2020

Import nanopb without touching CocoaPods imports #6165

Merged

paulb777 force-pushed the pb-spm-firestore branch from 8da13b2 to abde9e7 Compare July 30, 2020 21:58

paulb777 removed the GoogleDataTransport label Jul 30, 2020

paulb777 removed the api: crashlytics label Jul 30, 2020

paulb777 mentioned this pull request Jul 31, 2020

Remove non-existent Firestore/Protos/objc from podspec #6175

Merged

wilhuff approved these changes Jul 31, 2020

View reviewed changes

wilhuff assigned paulb777 and unassigned wilhuff Jul 31, 2020

paulb777 added 12 commits July 31, 2020 11:43

initial spm firestore

9e92df4

Update gRPC dep to resolve build time issue

52bfdb5

Package.swift fixes

6fa8b44

post rebase update

f9616d8

workaround nanopb imports to successfully build

27ccd85

another post rebase fix

5219317

swift test passes on iOS and macOS

8d6af14

Build FirebaseFirestoreSwift

156e354

Publish GoogleUtilities_UserDefaults for FirebaseUI

f744881

Revert "workaround nanopb imports to successfully build"

78c9878

This reverts commit bd0098a.

style

0979f33

sort excludes and remove Protos/objc

48e5c0f

paulb777 force-pushed the pb-spm-firestore branch from abde9e7 to 48e5c0f Compare July 31, 2020 18:43

paulb777 merged commit e69c701 into master Aug 1, 2020

paulb777 deleted the pb-spm-firestore branch August 1, 2020 15:43

firebase locked and limited conversation to collaborators Sep 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Firestore and Swift Package Manager #6072

Firestore and Swift Package Manager #6072

Uh oh!

paulb777 commented Jul 17, 2020 •

edited

Loading

Uh oh!

google-oss-bot commented Jul 17, 2020

Uh oh!

wilhuff Jul 30, 2020

Uh oh!

paulb777 Jul 30, 2020

Uh oh!

wilhuff Jul 30, 2020

Uh oh!

paulb777 Jul 30, 2020

Uh oh!

wilhuff Jul 30, 2020

Uh oh!

nidegen Aug 1, 2020 •

edited

Loading

Uh oh!

paulb777 commented Jul 30, 2020

Uh oh!

wilhuff left a comment

Uh oh!

Uh oh!

Firestore and Swift Package Manager #6072

Firestore and Swift Package Manager #6072

Uh oh!

Conversation

paulb777 commented Jul 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-oss-bot commented Jul 17, 2020

Uh oh!

wilhuff Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

paulb777 Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

wilhuff Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

paulb777 Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

wilhuff Jul 30, 2020

Choose a reason for hiding this comment

Uh oh!

nidegen Aug 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paulb777 commented Jul 30, 2020

Uh oh!

wilhuff left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

paulb777 commented Jul 17, 2020 •

edited

Loading

nidegen Aug 1, 2020 •

edited

Loading