Skip to content

Update Dangerfile, Firebase.h, and Firebase.podspec for launch readiness #6127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 12, 2020
Merged

Update Dangerfile, Firebase.h, and Firebase.podspec for launch readiness #6127

merged 4 commits into from
Aug 12, 2020

Conversation

schnecle
Copy link
Contributor

@schnecle schnecle commented Jul 24, 2020 •
edited
Loading

Check off a few updates for SDK launch readiness:

  • Update the Dangerfile
  • Update the Firebase.h header file
  • Update the Firebase.podspec file

#no-changelog This is part of the App Distribution initial launch

@google-oss-bot google-oss-bot added api: core zip-builder Tools related to building the zip file. labels Jul 24, 2020
@jeremydurham jeremydurham force-pushed the app-distribution-sdk-readiness branch 2 times, most recently from 7ce11ce to 6ef36ac Compare August 6, 2020 18:21
@schnecle schnecle force-pushed the app-distribution-sdk-readiness branch from 6ef36ac to f839adb Compare August 12, 2020 17:46
paulb777
paulb777 approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also update FirebasePodTest/Podfile

Also, not necessarily before M78, we should sync on Swift Package Manager and AppDistribution.

@paulb777 paulb777 added this to the 6.31.0 - M78 milestone Aug 12, 2020
@schnecle schnecle merged commit 89d1d20 into master Aug 12, 2020
@paulb777 paulb777 deleted the app-distribution-sdk-readiness branch August 19, 2020 00:14
@firebase firebase locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@ryanwilson ryanwilson Awaiting requested review from ryanwilson

Assignees
No one assigned
Labels
api: appdistribution api: core cla: yes zip-builder Tools related to building the zip file.
Projects
None yet
Milestone
6.31.0 - M78
Development

Successfully merging this pull request may close these issues.
5 participants
@schnecle @paulb777 @googlebot @google-oss-bot @jeremydurham