Port StringPrintf from //base #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves having to redefine all the libraries that abseil defines as imported libraries.
Cut the log out of the name to reflect that these will get more components besides just logging.
Prefer this to approaches based on variadic templates. While the variadic template mechanisms are strictly safer, they result in binary bloat we can't afford. This is essentially the same StringPrintf previously open sourced as a part of protobuf, though updated for C++11 which saves a copy and a temporary buffer on the heap.
zxu123
approved these changes
Jan 7, 2018
|
These changes don't come from Abseil (nor does Abseil plan to release them). This is from google3 //base and from the point of view of the Abseil team this approach is the legacy approach. As noted in the description though this approach is better for us because:
|
Merged
zxu123
pushed a commit
that referenced
this pull request
Jan 8, 2018
* Update CHANGELOG for macOS AppKit dependency. (#609) * Add Community Supported tvOS (#590) Add Community Supported tvOS for Core, Auth, Database and Storage. Add tvOS unit tests Add tvOS sample app Update README.md Add tvOS to travis testing * Adds API Test for Email Update (#613) * update Gemfile for Travis (#620) * update Travis to Xcode 9.2 (#619) * Removing an obsolete setting from plist files (#617) * Removing an obsolete setting from plist files * Fixing Unit Tests * Fixing nullability * Fully qualify protoc-generated outputs (#626) * Fully-qualify imports in the protocol compiler output * pbxproj updates from running pod update * New checked-in proto outputs * Port StringPrintf from //base (#624) * Port StringPrintf from //base. Prefer this to approaches based on variadic templates. While the variadic template mechanisms are strictly safer, they result in binary bloat we can't afford. This is essentially the same StringPrintf previously open sourced as a part of protobuf, though updated for C++11 which saves a copy and a temporary buffer on the heap. * Add abseil as a subdirectory of Firestore This saves having to redefine all the libraries that abseil defines as imported libraries. * Rename firebase_firesture_util_log_* targets Cut the log out of the name to reflect that these will get more components besides just logging. * Update tests for firebase_firestore_util renames
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
* Port StringPrintf from //base. Prefer this to approaches based on variadic templates. While the variadic template mechanisms are strictly safer, they result in binary bloat we can't afford. This is essentially the same StringPrintf previously open sourced as a part of protobuf, though updated for C++11 which saves a copy and a temporary buffer on the heap. * Add abseil as a subdirectory of Firestore This saves having to redefine all the libraries that abseil defines as imported libraries. * Rename firebase_firesture_util_log_* targets Cut the log out of the name to reflect that these will get more components besides just logging.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer this to approaches based on variadic templates. While the variadic template mechanisms are strictly safer, they result in binary bloat we can't afford.
This is essentially the same StringPrintf previously open sourced as a part of protobuf. If we do end up actually linking against protobuf we can remove this port. At this point since we're leaning toward using nanopb it seems reasonable to just add this now.
I've also slightly rearranged the CMake build to make it clearer how the platform-specific bits in firebase/firestore/util fit together.
@zxu123 This should make some the feedback I gave in #612 much easier to deal with.