Remove the extension that makes NSDate ServerTimestampWrappable. #6247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns out not to actually work because NSDate does not conform to Codable. Users can supply their own extensions that make NSDate conform to Codable and also supply an extension like this one to make NSDate conform to ServerTimestampWrappable. Add a test that verifies ServerTimestamps of Dates actually work. The equivalent test for NSDate does not compile.
|
Discovered while adding tests for the PR addressing #6237. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns out not to actually work because
NSDatedoes not conform toCodable. Users can supply their own extensions that makeNSDateconform toCodableand also supply an extension like this one to makeNSDateconform toServerTimestampWrappable.Add a test that verifies ServerTimestamps of Swift
Dateactually work. The equivalent test forNSDatedoes not compile.