Restore Firebase.h to pre-6.28.0 style #6367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksymmalyhin
approved these changes
Aug 28, 2020
paulb777
added a commit
that referenced
this pull request
Aug 28, 2020
* Restore Firebase.h now that SPM supports same public header path as CocoaPods
paulb777
added a commit
that referenced
this pull request
Aug 31, 2020
* Restore Firebase.h to pre-6.28.0 style (#6367) * Restore Firebase.h now that SPM supports same public header path as CocoaPods * Version 6.31.1
thebrianchen
pushed a commit
that referenced
this pull request
Sep 8, 2020
* Restore Firebase.h now that SPM supports same public header path as CocoaPods
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that SPM supports same public header path as CocoaPods
It seems the ifdef around FirebaseCore.h contributed to an Xcode build race condition where the app could try to build before FirebaseCore.
Fix #6341