Skip to content

Add version check to style.sh to make sure folks are running the same version. #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Add version check to style.sh to make sure folks are running the same version. #638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d919ce1
Add version check to style.sh to make sure folks are running the same…
Jan 10, 2018
a80ec22
Add homebrew instructions for upgrading.
Jan 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions scripts/style.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@

set -euo pipefail

if [[ $(clang-format --version) != **"version 6"** ]]; then
echo "Please upgrade to clang-format version 6."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add instructions - brew upgrade clang-format

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, done.

echo "If it's installed via homebrew you can run: brew upgrade clang-format"
exit 1
fi

(
if [[ $# -gt 0 ]]; then
if git rev-parse "$1" -- >& /dev/null; then
Expand Down