Convert FIRGetOptions to use instance methods (only) #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
reviewed
Feb 1, 2018
| @@ -65,7 +62,7 @@ typedef NS_ENUM(NSUInteger, FIRGetSource) { | |||
| /** | |||
| * Initializes the get options with the specified source. | |||
| */ | |||
| + (instancetype)optionsWithSource:(FIRGetSource)source NS_SWIFT_NAME(source(_:)); | |||
| - (instancetype)optionsWithSource:(FIRGetSource)source NS_SWIFT_NAME(source(_:)); | |||
There was a problem hiding this comment.
optionsWithSource suggests immutability. Perhaps this should be setSource?
There was a problem hiding this comment.
If it's an initializer, it should be
- (instancetype)initWithSource:(FIRGetSource)sourceThe Swift name will automatically be synthesized to init(source:).
|
The last commit on here predates our finalizing discussion on this topic. Please update and reassign once it's ready for another pass. |
|
Further work will be in #826. (This PR converts the already-submitted-to-firestore-api-changes-branch-but-not-master work to a style that we've decided we don't want.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.